Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading comments much slower than original Vue HackerNews #265

Open
yehosef opened this issue Nov 28, 2017 · 2 comments
Open

Loading comments much slower than original Vue HackerNews #265

yehosef opened this issue Nov 28, 2017 · 2 comments

Comments

@yehosef
Copy link

yehosef commented Nov 28, 2017

If I open something with a reasonably large amount of comments
https://vue-hn.now.sh/item/15790687 (255 comments as of now)
vs
http://vuejs.github.io/vue-hackernews/#!/item/15790687

and the difference is huge. It takes me about 1.5-2 seconds to render all the comments on the V1 version and about 4.5 seconds on V2.

Is it possible to speed things up or is it a result of Vue2 or the vuex? (I hope not..)

@yehosef
Copy link
Author

yehosef commented Nov 28, 2017

Also the JS heap:
V1 goes up to 42MB , final at 33MB
V2 goes up to 140 MB and stays there

@lemind
Copy link

lemind commented Dec 25, 2017

Hi. It happens because two reason which I found:

  1. Recursive calling api when fetching comments. I have fixed it in PR
  2. Loader hide and comments show when all comments will be fetched. If we want to see comments quickly we have to show comments earlier when first N comments will be fetched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants