Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-shapes-2] Some arc and curve command parameters should not be optional #10697

Closed
cdoublev opened this issue Aug 6, 2024 · 3 comments
Closed

Comments

@cdoublev
Copy link
Collaborator

cdoublev commented Aug 6, 2024

Following this resolution and the accepted PR, the syntax of <arc-command> is arc [[<by-to> <coordinate-pair>] || [of <length-percentage>{1,2}] || <arc-sweep>? || <arc-size>? || [rotate <angle>]?].

<by-to> <coordinate-pair> and of <length-percentage>{1,2} are now optional but this does not seem to be the intent of the resolution: "switch to using, allow reordering grammar".

The same problem applies to:

If this is not intentional, I suggest:

<arc-command> = arc [
     <by-to> <coordinate-pair>
  && of <length-percentage>{1,2}
  && <arc-sweep>?
  && <arc-size>?
  && [rotate <angle>]?
]
<curve-command> = curve [<by-to> <coordinate-pair> && using <coordinate-pair>{1,2}]
<smooth-command> = smooth [<by-to> <coordinate-pair> && [using <coordinate-pair>]?]
@cdoublev cdoublev changed the title [css-shapes-2] Arc size and smooth curve endpoint should not be optional [css-shapes-2] Some arc and smooth curve command parameters should not be optional Aug 6, 2024
@cdoublev cdoublev changed the title [css-shapes-2] Some arc and smooth curve command parameters should not be optional [css-shapes-2] Some arc and curve command parameters should not be optional Aug 6, 2024
@noamr
Copy link
Collaborator

noamr commented Sep 25, 2024

Seems right, I can prepare a PR (I don't think we need a new resolution)

@noamr
Copy link
Collaborator

noamr commented Jan 27, 2025

This is fixed

@noamr noamr closed this as completed Jan 27, 2025
@cdoublev
Copy link
Collaborator Author

Thanks btw.

Link to the related change: ddcbffd#diff-8456ef5bba8c9386e8c499974f617d442407c3404ff7bb0b19fee3d1f9671ef6R194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants