libwebsockets not linking against libdl

[neheb]

Certain configurations of glibc need -ldl to LDFLAGS to be passed. First noticed here: openwrt/packages#12222

I don't see any find_library calls to dl.

[lws-team]

For lws own use of dl, for plugins, he adds it to the dependent libs for lws library link-time.

How are you thinking we should determine if we should always link against dl because the libc wants it?

[neheb]

I would guess to do so unconditionally. I don't know how other projects do it.

[neheb]

Or this: https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html

edit: hmmmmm..... https://github.com/warmcat/libwebsockets/blob/master/CMakeLists.txt#L543

[lws-team]

edit: hmmmmm..... https://github.com/warmcat/libwebsockets/blob/master/CMakeLists.txt#L543

Yes as I said if lws is using plugins itself and needs libl, it will link with it.

I can't just add -ldl because it's perfectly possible to build for, eg, cross freertos and no libdl concept.

I didn't understand what the openwrt error is about either, it seems to be for another package that brings in libwebsockets... so - I am asking rather than trying to dodge it - why is it a lws issue?

[neheb]

The original report seems to be wrong. Closing.