Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect condition for check result produce crash #11

Open
marakew opened this issue Nov 20, 2019 · 0 comments
Open

incorrect condition for check result produce crash #11

marakew opened this issue Nov 20, 2019 · 0 comments

Comments

@marakew
Copy link

marakew commented Nov 20, 2019

if we have error for load dll at here
https://github.com/wbenny/pdbex/blob/master/Source/PDB.cpp#L77
we are skip this condition
https://github.com/wbenny/pdbex/blob/master/Source/PDB.cpp#L115
FAILED check for < 0 then we return FALSE
so we crash when continue to deref pointer m_DataSource here
https://github.com/wbenny/pdbex/blob/master/Source/PDB.cpp#L152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant