Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Geopandas >= 0.14.3 #118

Open
atmorling opened this issue Apr 16, 2024 · 1 comment
Open

Support Geopandas >= 0.14.3 #118

atmorling opened this issue Apr 16, 2024 · 1 comment
Assignees

Comments

@atmorling
Copy link
Contributor

atmorling commented Apr 16, 2024

EcoDataFrame wraps GeoDataFrame, and assumes that when we call Geopandas/Pandas methods on EcoDataFrame objects that an EcoDataFrame is returned.

0.14.3 breaks that assumption in a few places, with internal methods that are marked @final meaning we can't wrap them on our side.

Because of that, 'supporting' 0.14.3 will probably mean updating our notebooks/documentation and tests to capture scenarios where a user will have convert back to an EcoDataFrame after certain operations

@atmorling atmorling self-assigned this Apr 16, 2024
@atmorling
Copy link
Contributor Author

After a chat with @cisaacstern, an infinitely better way to do this is to rework our Base classes as dataframe accessors

This puts some pressure on getting #108 completed, so will raise the priority there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant