Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chicken-egg notebook versioning issue #413

Open
atmorling opened this issue Feb 10, 2025 · 0 comments
Open

Fix chicken-egg notebook versioning issue #413

atmorling opened this issue Feb 10, 2025 · 0 comments

Comments

@atmorling
Copy link
Contributor

Currently when cutting a new release, one has to update the version tag in the notebooks to the tag that doesn't exist yet, in order for the docs build of the release to refer to the correct version.

This causes an issue if done via a PR in that the notebook tests will fail, and committing to main isn't ideal.

Options I can think of:

  • Add a label to optionally skip notebook tests for a pre-release PR
  • Have elebot generate the PR based on a workflow_dispatch and skip the notebook tests in this case
  • Move the docs / notebook build out of this repo entirely (probably more effort than necessary for now)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant