Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include type information #78

Closed
cj81499 opened this issue Oct 30, 2022 · 2 comments · Fixed by #131
Closed

Include type information #78

cj81499 opened this issue Oct 30, 2022 · 2 comments · Fixed by #131

Comments

@cj81499
Copy link
Contributor

cj81499 commented Oct 30, 2022

I like to type check my Python code with mypy, but this library doesn't provide any type hints.

See PEP 561 for more info.

I haven't contributed types to a library before, but I may give it a shot myself if you're open to contributions from others.

@wimglenn
Copy link
Owner

wimglenn commented Oct 30, 2022

I don’t use mypy but I’m not against it if someone else wants to make it work. We do still support Python 2, though, because in several problem cases for advent of code pypy2 is still significantly faster than any Python 3.X

@cj81499
Copy link
Contributor Author

cj81499 commented Oct 30, 2022

Sure thing! I've actually already started on this locally and hope to push to my fork soon.

I've been using "inline" (Python 3) style hints (it's much easier to write them this way), but I'll have to revise it to use type stubs (or type comments) before merge (or, drop python 2 support, but it's totally reasonable to prefer to keep compatibility).

I'll probably open a (very early) draft PR so you can start to look if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants