Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webLinks plugin issue. Wrong behaviour on selection #1947

Closed
vitaliy-codeocean opened this issue Feb 17, 2019 · 1 comment
Closed

webLinks plugin issue. Wrong behaviour on selection #1947

vitaliy-codeocean opened this issue Feb 17, 2019 · 1 comment
Labels
help wanted type/bug Something is misbehaving
Milestone

Comments

@vitaliy-codeocean
Copy link

If i will finish selection in the middle of some link and release mouse button, link will be clicked.
So in general im just trying to copy part of the text but opening link in the end :)

Details

  • Browser and browser version: Google Chrome Version 72.0.3626.109
  • OS version: macOS 10.14.3
  • xterm.js version: 3.11.0

Steps to reproduce

  1. Start to select text
  2. Stop when your cursor will be over some link
  3. Link is opened
@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2019

I guess to prevent this we could make sure not selection change has occurred (or no selection exists?) when a link is about to be activated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants