Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automating addon releases during xterm release #2411

Closed
Tyriar opened this issue Sep 10, 2019 · 2 comments
Closed

Automating addon releases during xterm release #2411

Tyriar opened this issue Sep 10, 2019 · 2 comments
Assignees
Labels
type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 10, 2019

I was just writing up the v4 release notes and it occurred to me that we could automate the version bumping of addons (#2410) when a stable version changed. We could do this by identifying the changed files between the previous release tag (latest on npm) and HEAD, instead of just the commit that we do here:

xterm.js/bin/publish.js

Lines 111 to 117 in 26a09f0

function getChangedFilesInCommit(commit) {
const args = ['log', '-m', '-1', '--name-only', `--pretty=format:`, commit];
const result = cp.spawnSync('git', args);
const output = result.stdout.toString();
const changedFiles = output.split('\n').filter(e => e.length > 0);
return changedFiles;
}

Then if files changed within the addon, do a new stable release. In order to keep to semver's breaking changes we could just assume any change to an addon is a breaking change with a previous version and bump major here.

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Sep 10, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Sep 10, 2019

Linked this to #1921

@Tyriar Tyriar added this to the 4.2.0 milestone Oct 7, 2019
@Tyriar Tyriar self-assigned this Oct 7, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Oct 17, 2019

Closing for now, let's do this manually a little more until we automate

@Tyriar Tyriar closed this as completed Oct 17, 2019
@Tyriar Tyriar removed this from the 4.2.0 milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

No branches or pull requests

1 participant