Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Certain font name prefixes are missing (semi vs demi, extra-bold etc) #14

Open
shehi opened this issue May 28, 2015 · 1 comment

Comments

@shehi
Copy link
Contributor

shehi commented May 28, 2015

Hey @zoltan-dulac :

As I was working with certain fonts from Google WebFonts, I noticed you are missing certain font name prefixes when convertFonts.sh is determining the numeric value for font-weight CSS property.

As a basis, let's look at OpenSans fonts: https://github.com/google/fonts/tree/master/apache/opensans

As you can see, this font has SemiBold variants. Your blog at:

http://www.useragentman.com/blog/2013/09/20/better-web-typography-with-font-weight-autohinting-and-font-feature-settings/#comment-911845

does list only DemiBold with weight value of 600. I believe SemiBold also should be treated with the same value.

Additionally, your table in that blog-post also mentions ExtraBold with font-weight value 800. However when I converting OpenSans, I got following CSS output:

@font-face {
  font-family: 'OpenSans';
  src: url('public/fonts/opensans/OpenSans-ExtraBold.eot?') format('eot'),
       url('public/fonts/opensans/OpenSans-ExtraBold.woff2') format('woff2'),
       url('public/fonts/opensans/OpenSans-ExtraBold.woff') format('woff'),
       url('public/fonts/opensans/OpenSans-ExtraBold.ttf')  format('truetype');
  font-weight: 700;
  font-style: normal;
}

As you can see the font-weight value in the output is 700 instead of 800. Is this a bug?

That's it for the moment. Thanks a lot for such a wonderful tool! :)

@shehi
Copy link
Contributor Author

shehi commented May 2, 2018

Ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant