Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x13 and timetravel support #131

Open
kiahmed opened this issue Oct 11, 2017 · 35 comments
Open

x13 and timetravel support #131

kiahmed opened this issue Oct 11, 2017 · 35 comments

Comments

@kiahmed
Copy link

kiahmed commented Oct 11, 2017

hi, i am new to pool and nomp configuration and stuff. i somehow managed to configure and run it for ltc. I wonder how can i add support for coins that didn't ship with the bundle like marucoin/x13 and timetravel 10 algorithm?

thanks for any help..

@hardx4
Copy link

hardx4 commented Nov 24, 2017

I was able to implement the Bitcore currency that works in timetravel10, but I can not solve the problem of rejected shares. 100% of the shares are rejected.

@kiahmed
Copy link
Author

kiahmed commented Nov 24, 2017

@hardx4 could you shed some more light on where to get a the algorithm files for each coin that this stratum pool would understand and work with? For bitcore, did you have to download timetravel10 file from anywhere or created your own or something?

@hardx4
Copy link

hardx4 commented Nov 25, 2017

@kiahmed See my repository. Well, I downloaded the timetravel of a pool that supports the coin in your stratum. I downloaded it here: https://github.com/tpruvot/yiimp. It seems to work fine, but it does not accept the shares.

My issue: #132

@kiahmed
Copy link
Author

kiahmed commented Nov 25, 2017

yup. i looked into that repo too..he has wide range of coins setup and entire package. So, why wouldn't you rather use that stratum service see if it doesn't has the sharing problem or you already have infrastructure running on this repo? Thats exactly my concern is how do you make sure the stratum is all happy with the newly incorporated algo. I think I tried marucoin with this one and it had some issues.

@startsts
Copy link

startsts commented Dec 1, 2017

I recently added this algo to my pool (I use node-stratum), mining seems working, mulitplier at "algoProperties" I set multiplier: Math.pow(2, 8),

@hardx4
Copy link

hardx4 commented Dec 1, 2017

@startsts, Timetravel10 or Timetravel?

@hardx4
Copy link

hardx4 commented Dec 1, 2017

My something is factor equal to 1, I'm going to try to change it, it might solve my problems.

@startsts
Copy link

startsts commented Dec 1, 2017

In my case is Timetravel, but I think Timetravel10 has same multiplier.
Btw: do you have polytimos working at your multi-hashing?

@hardx4
Copy link

hardx4 commented Dec 1, 2017

@startsts yes i have.

@hardx4
Copy link

hardx4 commented Dec 1, 2017

@startsts I will try to change the timetravel10 multiplier and I will test, I believe it will work!

@startsts
Copy link

startsts commented Dec 1, 2017

I have seen your code for timetravel10 https://github.com/hardx4/node-multi-hashing/blob/master/timetravel10.c and wonder it has only 7 algos instead of 10, from where is that code?

@hardx4
Copy link

hardx4 commented Dec 1, 2017

This version is one of many that I tested, I will return to a version with 9 cases instead of 7

@startsts
Copy link

startsts commented Dec 2, 2017

And yes... I was working on timetravel10 and got same problem with reject shares and it was not depend on multiplier. Now I have taken some code from cpuminer-multi, it seems working, I pulled to my repository, I hope this help https://github.com/startsts/multi-hashing/blob/master/bitcore.c

@hardx4
Copy link

hardx4 commented Dec 10, 2017

@startsts I tested the code but continued to reject the shares. So I put in multiplier: Math.pow (2, 8) and the shares were accepted. But I still do not know if this is correct.

@startsts
Copy link

startsts commented Dec 11, 2017

@hardx4 yes, i was talking about Math.pow (2, 8) above. To know if wallet will accept block we can try to use testnet or some coin with low difficulty and try mining it. I never created testnet so I don't know how to do it. I recently added Bitcore coin to my pool, but there are no miners yet, so nobody checked . Any other coin with timetravel10?

@hardx4
Copy link

hardx4 commented Dec 11, 2017

@startsts I do not know the same way. I tried to start in testnet, but apparently there are no nodes available. What is your pool?

@startsts
Copy link

my pool is https://cryptohub.online/pools/, any ideas? Surely there are no nodes for testnet, you should launch 2 wallet instances on the same computer and connect one to another

@hardx4
Copy link

hardx4 commented Dec 12, 2017

I have bitcore installed on the server, I can start in testnet with your added node and you in the same way with my added node. Would that solve it?
How can we communicate more easily? skype, slack, discord ...

@startsts
Copy link

I don't have broadband connection these days so I can't help. How I say you can launch 2 daemon instances in one PC, just use different -datadir. I used this way when was checking tribus algo

@hardx4
Copy link

hardx4 commented Dec 12, 2017

@startsts I have just tested in testnet and the daemon refuses the generated blocks ...

@startsts
Copy link

Can you see in debug.log what the reason?

@startsts
Copy link

I tried testnet and everything is ok, daemon accepts blocks, screenshot
screenshot at 2017-12-13 01-54-13

@hardx4
Copy link

hardx4 commented Dec 13, 2017

@startsts Here the blocks are not accepted =/

@startsts
Copy link

Look at debug.log

@hardx4
Copy link

hardx4 commented Dec 13, 2017

@startsts How's your shareMultiplier for the algorithm?
I'll give you the log, one minute

@startsts
Copy link

bitcore: {
multiplier: Math.pow(2, 8),
hash: function(){
return function(){
return multiHashing.bitcore.apply(this, arguments);
}
}
},

@hardx4
Copy link

hardx4 commented Dec 13, 2017

Let me compile again

@hardx4
Copy link

hardx4 commented Dec 13, 2017

@startsts look
image

@hardx4
Copy link

hardx4 commented Dec 13, 2017

@startsts If Daemon rejects the block, why does it add the block to the chain, this I do not understand ...

@startsts
Copy link

daemon accepts block, but your stratum thinks that it doesn't since it return different block hash .. maybe need some changes to node-stratum-pool, I already did a lot of changes in code of node-stratum-pool to support more coins... when I will be able I publish my node-stratum-pool repository

@hardx4
Copy link

hardx4 commented Dec 13, 2017

@startsts I understood, I still do not know how to solve this problem.

@trustfarm-dev
Copy link

trustfarm-dev commented Jun 20, 2018

@hardx4 @startsts can you check my problem also?
zone117x/node-open-mining-portal#611

@hardx4 in case of me, making groestlmyriad algo pool. coin has different header hashing method.
in case of digibyte , they use blockhash with SHA256D , verge is use scrypt.
Can you check BTX source code what header hashing algorithm used.

@trustfarm-dev
Copy link

@hardx4 did you check balance? when Block rejected?
first check pool accounts' transaction.
if block found and accepted and wallet balance is added. then it is definitely blockhash issue.

@globaltoken
Copy link

@hardx4 I will copy your Code into my Repo. I am working to add dozens of algorithms for NOMP. About 25 - 30. What is the problem you have?

Regards,

@globaltoken
Copy link

@hardx4 I think I found your issue.
Seems you are hashing in wrong way mate.

You are hashing hashA, hashB, hashA, hashB. But it works this way:
hashA, hashB, hashB, hashA, hashA, hashB ..

I will fix this and let you know more! @kiahmed @trustfarm-dev @startsts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants