Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit shrinkwrap update after deploying NPM package #156

Closed
t1m0thyj opened this issue Feb 8, 2022 · 2 comments · Fixed by #157 or #160
Closed

Commit shrinkwrap update after deploying NPM package #156

t1m0thyj opened this issue Feb 8, 2022 · 2 comments · Fixed by #157 or #160

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Feb 8, 2022

should the shrinkwrap be included in the version-controller library so that the repo doesn't get out of sync when publishing new versions ?

Originally posted by @zFernand0 in zowe/zowe-cli#1306 (review)
@t1m0thyj t1m0thyj mentioned this issue Feb 9, 2022
Merged
@t1m0thyj
Copy link
Member Author

t1m0thyj commented Feb 9, 2022

The git add command does not appear to be working as expected:

+ git add package-lock.json npm-shrinkwrap.json --ignore-errors
fatal: pathspec 'package-lock.json' did not match any files

Example of build where this happened: https://wash.zowe.org:8443/job/brightside/job/master/821/console

@t1m0thyj t1m0thyj reopened this Feb 9, 2022
@t1m0thyj
Copy link
Member Author

We may now be able to run npm install --package-lock-only at the end of the version stage since npm/cli#3637 has been fixed.

@zFernand0 zFernand0 linked a pull request Feb 16, 2022 that will close this issue
Update PL/SW JSON file(s) before gitTag() #160
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@t1m0thyj