Swipe to reply send #1016
Open
Swipe to reply send #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngkidwarrior
force-pushed
the
swipe_to_reply_send
branch
2 times, most recently
from
4e02b67 to
61c3e32
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
youngkidwarrior
force-pushed
the
swipe_to_reply_send
branch
from
61c3e32 to
461f7c8
Compare
| containerStyle={{ backgroundColor: 'transparent' }} | ||
| hitSlop={{ right: -20 }} | ||
| onSwipeableWillClose={handleOnSwipeableWillClose} | ||
| ref={() => swipeableRef} |
There was a problem hiding this comment.
The ref callback is using an arrow function that returns nothing (() => swipeableRef), which won't properly store the Swipeable reference. Change to ref={swipeableRef} to correctly capture the component instance.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| @@ -146,7 +146,7 @@ export const TokenDetailsMarketData = ({ coin }: { coin: CoinWithBalance }) => { | |||
| <Spinner size="small" color={'$color12'} /> | |||
| ) : ( | |||
| <XStack gap={'$1.5'} ai="center" jc={'space-around'}> | |||
| {changePercent24h === undefined ? ( | |||
| {!changePercent24h ? ( | |||
There was a problem hiding this comment.
Using !changePercent24h will evaluate to true when changePercent24h is 0, which is a valid percentage change value that should be displayed. The original check for changePercent24h === undefined was correct since it specifically tests for the loading/error state.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
youngkidwarrior
force-pushed
the
swipe_to_reply_send
branch
from
461f7c8 to
7d0c711
Compare
0xBigBoss
reviewed
Jan 26, 2025
packages/app/package.json
Outdated
There was a problem hiding this comment.
be sure to add react-native-reanimated too
0xBigBoss
reviewed
Jan 26, 2025
0xBigBoss
reviewed
Jan 26, 2025
apps/next/pages/_app.tsx
Outdated
There was a problem hiding this comment.
let's also follow the web setup guide for reanimated. https://docs.swmansion.com/react-native-reanimated/docs/guides/web-support/
youngkidwarrior
force-pushed
the
swipe_to_reply_send
branch
from
7d0c711 to
a11dc52
Compare
|
Vercel Unique URL: https://sendapp-de7750g1t-0xsend.vercel.app |
Playwright ReportSummary
Suitesaccount-rewards.onboarded.spec.tscan visit rewards page
account-sendtag-checkout.onboarded.spec.tscan visit checkout page
can add a pending tag
cannot add an invalid tag name
can confirm a tag
can refer a tag
can refer multiple tags in separate transactions
cannot confirm a tag without paying
cannot add more than 5 tags
account-settings-backup.onboarded.spec.tscan backup account
can remove a signer
account.logged-in.spec.tscan visit account page
can update profile
activity.onboarded.spec.tscan visit activity page and see correct activity feed
can search on activity page
home.onboarded.spec.tscan visit token detail page
leaderboard.logged-in.spec.tscan visit leaderboard page
onboarding.logged-in.spec.tscan visit onboarding page
profile.anon.spec.tsanon user can visit public profile
anon user cannot visit private profile
profile.logged-in.spec.tslogged in user needs onboarding before visiting profile
profile.onboarded.spec.tscan visit other user profile and send by tag
can visit my own profile
can visit private profile
can view activities between another profile
send-token-upgrade.onboarded.spec.tscan upgrade their Send Token V0 to Send Token V1
send.onboarded.spec.tscan send USDC starting from profile page
can send USDC using tag starting from home page
can send USDC using sendid starting from home page
can send USDC using address starting from home page
can send ETH starting from profile page
can send ETH using tag starting from home page
can send ETH using sendid starting from home page
can send ETH using address starting from home page
can send SEND starting from profile page
can send SEND using tag starting from home page
can send SEND using sendid starting from home page
can send SEND using address starting from home page
sign-in.anon.spec.tsredirect on sign-in
redirect to send confirm page on sign-in
sign-up.anon.spec.tscan sign up
country code is selected based on geoip
skip otp for existing user trying to sign up using already used phone number
user can sign in with passkey from backing up page
user can sign in as back up using otp from backing up page
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.