Dummy UI for earn #1045

musidlo · 2025-01-25T17:48:43Z

TODO:

main earn screen
- plug active earnings numbers
- show loader when numbers are loading
start earning form
- calculate APY and bonuses when deposit amount changes
- show loader when numbers are loading
- plug links to terms
- add tooltip with details of APY
active earnings screen
- plug active earnings numbers
withdraw form
- plug deposit balance
- calculate how APY and bonuses will change
- show loader when numbers are loading
- plug links to terms
earnings balance screen
- plug earnings balance
- show loader when number are loading
- add support for earnings related activities in list and details
- filter activities to show only earnings related
rewards balance screen
- plug rewards balance
- show loader when numbers are loading
- add support for rewards related activites in list and details
- filter activities to show only rewards related

packages/app/features/earn/screen.tsx

0xBigBoss · 2025-01-30T02:28:54Z

packages/app/features/earn/EarningForm.tsx

+    parsedAmount > BigInt(0) &&
+    areTermsAccepted
+
+  const insufficientAmount =


Try to use the form error instead.

form.setError('amount', { type: 'custom', message: 'Insufficient balance' })

Then you can get the error like

const form = useForm() form.formState.errors.amount const { errors } = useFormState() errors.amount

0xBigBoss · 2025-01-30T02:30:04Z

packages/app/features/earn/WithdrawForm.tsx

+
+  const canSubmit = depositBalance >= parsedAmount && parsedAmount > BigInt(0) && areTermsAccepted
+
+  const insufficientAmount = earnParams.amount !== undefined && parsedAmount > depositBalance


same here. try to leverage the form state. https://react-hook-form.com/docs/useform

packages/app/components/sidebar/HomeSideBar.tsx

0xBigBoss

Mostly looks good to me. Let's be sure to hide it in the UI in production. Only show it in local dev in the sidebar.

github-actions · 2025-02-16T18:07:30Z

Vercel Unique URL: https://sendapp-5qawtug7k-0xsend.vercel.app
Vercel Preview URL: sendapp-earn-ui-0xsend.vercel.app
Last Commit: 4c60a06

github-actions · 2025-02-16T18:11:16Z

Playwright Report

Summary

Expected	Skipped	Unexpected	Flaky	Duration
81	6	0	3	226.56s

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

chromium: ✅
firefox: ✅

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

chromium: ✅
firefox: ✅

can add a pending tag

chromium: ✅
firefox: ✅

cannot add an invalid tag name

chromium: ✅
firefox: ✅

can confirm a tag

chromium: 🚨
firefox: ✅

can refer a tag

chromium: 🚨
firefox: ✅

can refer multiple tags in separate transactions

chromium: ✅
firefox: ✅

cannot confirm a tag without paying

chromium: ✅
firefox: ✅

cannot add more than 5 tags

chromium: ✅
firefox: ✅

account-settings-backup.onboarded.spec.ts

can backup account

chromium: ✅
firefox: ✅

can remove a signer

chromium: ✅
firefox: ✅

account.logged-in.spec.ts

can visit account page

chromium: ✅
firefox: ✅

can update profile

chromium: ✅
firefox: ✅

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

chromium: ✅
firefox: ✅

can search on activity page

chromium: ✅
firefox: ✅

home.onboarded.spec.ts

can visit token detail page

chromium: ✅
firefox: ✅

leaderboard.logged-in.spec.ts

can visit leaderboard page

chromium: ✅
firefox: ✅

onboarding.logged-in.spec.ts

can visit onboarding page

chromium: ✅
firefox: ✅

profile.anon.spec.ts

anon user can visit public profile

chromium: ✅
firefox: ✅

anon user cannot visit private profile

chromium: ✅
firefox: ✅

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

chromium: ✅
firefox: ✅

profile.onboarded.spec.ts

can visit other user profile and send by tag

chromium: ✅
firefox: ✅

can visit my own profile

chromium: ✅
firefox: ✅

can visit private profile

chromium: ✅
firefox: ✅

can view activities between another profile

chromium: ✅
firefox: ✅

send-token-upgrade.onboarded.spec.ts

can upgrade their Send Token V0 to Send Token V1

chromium: ✅
firefox: ✅

send.onboarded.spec.ts

can send USDC starting from profile page

chromium: ✅
firefox: ✅

can send USDC using tag starting from home page

chromium: ✅
firefox: ✅

can send USDC using sendid starting from home page

chromium: ✅
firefox: ✅

can send USDC using address starting from home page

chromium: ✅
firefox: ✅

can send ETH starting from profile page

chromium: 🚨
firefox: ✅

can send ETH using tag starting from home page

chromium: ✅
firefox: ✅

can send ETH using sendid starting from home page

chromium: ✅
firefox: ✅

can send ETH using address starting from home page

chromium: ✅
firefox: ✅

can send SEND starting from profile page

chromium: ✅
firefox: ✅

can send SEND using tag starting from home page

chromium: ✅
firefox: ✅

can send SEND using sendid starting from home page

chromium: ✅
firefox: ✅

can send SEND using address starting from home page

chromium: ✅
firefox: ✅

sign-in.anon.spec.ts

redirect on sign-in

chromium: ✅
firefox: ✅

redirect to send confirm page on sign-in

chromium: ✅
firefox: ✅

sign-up.anon.spec.ts

can sign up

chromium: ✅
firefox: ✅

country code is selected based on geoip

chromium: ✅
firefox: ✅

skip otp for existing user trying to sign up using already used phone number

chromium: ⏭
firefox: ⏭

user can sign in with passkey from backing up page

chromium: ⏭
firefox: ⏭

user can sign in as back up using otp from backing up page

chromium: ⏭
firefox: ⏭

musidlo requested a review from 0xBigBoss as a code owner January 25, 2025 17:48

musidlo marked this pull request as draft January 25, 2025 17:48

graphite-app bot reviewed Jan 25, 2025

View reviewed changes

packages/app/features/earn/screen.tsx Show resolved Hide resolved

0xBigBoss reviewed Jan 30, 2025

View reviewed changes

packages/app/components/sidebar/HomeSideBar.tsx Show resolved Hide resolved

0xBigBoss approved these changes Jan 30, 2025

View reviewed changes

musidlo force-pushed the earn-ui branch from be43fe1 to f9fd76b Compare January 31, 2025 16:30

musidlo changed the title ~~Added first part of dummy UI for earn~~ Dummy UI for earn Feb 5, 2025

musidlo added 5 commits February 16, 2025 11:55

Added first part of dummy UI for earn

f038508

Added earning form screen

136a33f

Added active earnings screen

7b9b62b

Added withdraw form

25471f1

Added earnings and rewards balance

4c60a06

0xBigBoss force-pushed the earn-ui branch from f9fd76b to 4c60a06 Compare February 16, 2025 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dummy UI for earn #1045

Dummy UI for earn #1045

musidlo commented Jan 25, 2025 •

edited

Loading

0xBigBoss Jan 30, 2025

0xBigBoss Jan 30, 2025

0xBigBoss left a comment

github-actions bot commented Feb 16, 2025

github-actions bot commented Feb 16, 2025


		const canSubmit = depositBalance >= parsedAmount && parsedAmount > BigInt(0) && areTermsAccepted

		const insufficientAmount = earnParams.amount !== undefined && parsedAmount > depositBalance

Dummy UI for earn #1045

Are you sure you want to change the base?

Dummy UI for earn #1045

Conversation

musidlo commented Jan 25, 2025 • edited Loading

0xBigBoss Jan 30, 2025

Choose a reason for hiding this comment

0xBigBoss Jan 30, 2025

Choose a reason for hiding this comment

0xBigBoss left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 16, 2025

github-actions bot commented Feb 16, 2025

Playwright Report

Summary

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

can add a pending tag

cannot add an invalid tag name

can confirm a tag

can refer a tag

can refer multiple tags in separate transactions

cannot confirm a tag without paying

cannot add more than 5 tags

account-settings-backup.onboarded.spec.ts

can backup account

can remove a signer

account.logged-in.spec.ts

can visit account page

can update profile

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

can search on activity page

home.onboarded.spec.ts

can visit token detail page

leaderboard.logged-in.spec.ts

can visit leaderboard page

onboarding.logged-in.spec.ts

can visit onboarding page

profile.anon.spec.ts

anon user can visit public profile

anon user cannot visit private profile

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

profile.onboarded.spec.ts

can visit other user profile and send by tag

can visit my own profile

can visit private profile

can view activities between another profile

send-token-upgrade.onboarded.spec.ts

can upgrade their Send Token V0 to Send Token V1

send.onboarded.spec.ts

can send USDC starting from profile page

can send USDC using tag starting from home page

can send USDC using sendid starting from home page

can send USDC using address starting from home page

can send ETH starting from profile page

can send ETH using tag starting from home page

can send ETH using sendid starting from home page

can send ETH using address starting from home page

can send SEND starting from profile page

can send SEND using tag starting from home page

can send SEND using sendid starting from home page

can send SEND using address starting from home page

sign-in.anon.spec.ts

redirect on sign-in

redirect to send confirm page on sign-in

sign-up.anon.spec.ts

can sign up

country code is selected based on geoip

skip otp for existing user trying to sign up using already used phone number

user can sign in with passkey from backing up page

user can sign in as back up using otp from backing up page

musidlo commented Jan 25, 2025 •

edited

Loading