Disable send route when sending is locked #1115

youngkidwarrior · 2025-02-19T11:03:31Z

No description provided.

youngkidwarrior · 2025-02-19T11:03:51Z

QA: Raise USDC min to test send lock #1116
Disable send route when sending is locked #1115 👈 (View in Graphite)
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

0xBigBoss

LGTM. My only gripe with the useCoins and useCoin hook is w don't provide an easy way for the caller to invalidate the queries so that we refetch. But that can be a follow up, things mostly work for the users cuz they refetch on mount.

github-actions · 2025-02-19T19:36:40Z

Vercel Unique URL: https://sendapp-m02caue9s-0xsend.vercel.app
Vercel Preview URL: sendapp-disable-send-route-when-sending-is-locked-0xsend.vercel.app
Last Commit: fce1f69

github-actions · 2025-02-19T19:48:52Z

Playwright Report

Summary

Expected	Skipped	Unexpected	Flaky	Duration
72	6	7	5	338.93s

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

chromium: ✅
firefox: ✅

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

chromium: ✅
firefox: ✅

can add a pending tag

chromium: ✅
firefox: ✅

cannot add an invalid tag name

chromium: ✅
firefox: ✅

can confirm a tag

chromium: ✅
firefox: ✅

can refer a tag

chromium: 🚨
firefox: ✅

can refer multiple tags in separate transactions

chromium: ✅
firefox: ✅

cannot confirm a tag without paying

chromium: ✅
firefox: ✅

cannot add more than 5 tags

chromium: ✅
firefox: ✅

account-settings-backup.onboarded.spec.ts

can backup account

chromium: ✅
firefox: ✅

can remove a signer

chromium: ✅
firefox: ✅

account.logged-in.spec.ts

can visit account page

chromium: ✅
firefox: ✅

can update profile

chromium: ✅
firefox: ✅

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

chromium: ✅
firefox: ✅

can search on activity page

chromium: ✅
firefox: ✅

home.onboarded.spec.ts

can visit token detail page

chromium: ✅
firefox: ✅

leaderboard.logged-in.spec.ts

can visit leaderboard page

chromium: ✅
firefox: ✅

onboarding.logged-in.spec.ts

can visit onboarding page

chromium: ✅
firefox: ✅

profile.anon.spec.ts

anon user can visit public profile

chromium: ❌
- Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m

Locator: getByRole('link', { name: 'SEND', exact: true })
Expected: visible
Received: <element(s) not found>
Call log:
�[2m- expect.toBeVisible with timeout 5000ms�[22m
�[2m - waiting for getByRole('link', { name: 'SEND', exact: true })�[22m

�[0m �[90m 27 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByText(profile�[33m.�[39mname))�[33m.�[39mtoBeVisible()
�[90m 28 |�[39m �[36mconst�[39m profilePage �[33m=�[39m �[36mnew�[39m �[33mProfilePage�[39m(page�[33m,�[39m { name�[33m:�[39m profile�[33m.�[39mname�[33m,�[39m about�[33m:�[39m profile�[33m.�[39mabout })
�[31m�[1m>�[22m�[39m�[90m 29 |�[39m �[36mawait�[39m expect(profilePage�[33m.�[39msendButton)�[33m.�[39mtoBeVisible()
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 30 |�[39m })
�[90m 31 |�[39m
�[90m 32 |�[39m test(�[32m'anon user cannot visit private profile'�[39m�[33m,�[39m �[36masync�[39m ({ page�[33m,�[39m seed }) �[33m=>�[39m {�[0m

at /home/runner/_work/sendapp/sendapp/packages/playwright/tests/profile.anon.spec.ts:29:40

firefox: ❌
- Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m

Locator: getByRole('link', { name: 'SEND', exact: true })
Expected: visible
Received: <element(s) not found>
Call log:
�[2m- expect.toBeVisible with timeout 5000ms�[22m
�[2m - waiting for getByRole('link', { name: 'SEND', exact: true })�[22m

�[0m �[90m 27 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByText(profile�[33m.�[39mname))�[33m.�[39mtoBeVisible()
�[90m 28 |�[39m �[36mconst�[39m profilePage �[33m=�[39m �[36mnew�[39m �[33mProfilePage�[39m(page�[33m,�[39m { name�[33m:�[39m profile�[33m.�[39mname�[33m,�[39m about�[33m:�[39m profile�[33m.�[39mabout })
�[31m�[1m>�[22m�[39m�[90m 29 |�[39m �[36mawait�[39m expect(profilePage�[33m.�[39msendButton)�[33m.�[39mtoBeVisible()
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 30 |�[39m })
�[90m 31 |�[39m
�[90m 32 |�[39m test(�[32m'anon user cannot visit private profile'�[39m�[33m,�[39m �[36masync�[39m ({ page�[33m,�[39m seed }) �[33m=>�[39m {�[0m

at /home/runner/_work/sendapp/sendapp/packages/playwright/tests/profile.anon.spec.ts:29:40

anon user cannot visit private profile

chromium: ❌
- Error: �[2mexpect(�[22m�[31mreceived�[39m�[2m).�[22mtoBe�[2m(�[22m�[32mexpected�[39m�[2m) // Object.is equality�[22m

Expected: �[32m"�[7m404 | �[27mSend"�[39m
Received: �[31m"Send"�[39m

�[0m �[90m 36 |�[39m �[36mawait�[39m visitProfile({ page�[33m,�[39m tag�[33m:�[39m tag�[33m.�[39mname })
�[90m 37 |�[39m �[36mconst�[39m title �[33m=�[39m �[36mawait�[39m page�[33m.�[39mtitle()
�[31m�[1m>�[22m�[39m�[90m 38 |�[39m expect(title)�[33m.�[39mtoBe(�[32m'404 | Send'�[39m)
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 39 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByRole(�[32m'heading'�[39m�[33m,�[39m { name�[33m:�[39m �[32m'Not found.'�[39m }))�[33m.�[39mtoBeVisible()
�[90m 40 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByRole(�[32m'link'�[39m�[33m,�[39m { name�[33m:�[39m �[32m'Need to sign in?'�[39m }))�[33m.�[39mtoBeVisible()
�[90m 41 |�[39m })�[0m

at /home/runner/_work/sendapp/sendapp/packages/playwright/tests/profile.anon.spec.ts:38:17

firefox: ✅

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

chromium: ❌
- Error: �[2mexpect(�[22m�[31mreceived�[39m�[2m).�[22mtoBe�[2m(�[22m�[32mexpected�[39m�[2m) // Object.is equality�[22m

Expected: �[32m"Send�[7m | Onboarding�[27m"�[39m
Received: �[31m"Send"�[39m

�[0m �[90m 26 |�[39m assert(�[33m!�[39m�[33m!�[39mprofile�[33m.�[39mabout�[33m,�[39m �[32m'profile about not found'�[39m)
�[90m 27 |�[39m �[36mawait�[39m page�[33m.�[39mgoto(�[32m${tag.name}�[39m)
�[31m�[1m>�[22m�[39m�[90m 28 |�[39m expect(�[36mawait�[39m page�[33m.�[39mtitle())�[33m.�[39mtoBe(�[32m'Send | Onboarding'�[39m)
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 29 |�[39m �[36mawait�[39m �[36mnew�[39m �[33mOnboardingPage�[39m(page)�[33m.�[39mcompleteOnboarding(expect)
�[90m 30 |�[39m
�[90m 31 |�[39m �[90m// @todo check that user is redirected back to profile page�[39m�[0m

at /home/runner/_work/sendapp/sendapp/packages/playwright/tests/profile.logged-in.spec.ts:28:30

firefox: ❌
- Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m

Locator: getByText('Rafaela Waters')
Expected: visible
Received: <element(s) not found>
Call log:
�[2m- expect.toBeVisible with timeout 5000ms�[22m
�[2m - waiting for getByText('Rafaela Waters')�[22m

�[0m �[90m 33 |�[39m �[36mconst�[39m profilePage �[33m=�[39m �[36mnew�[39m �[33mProfilePage�[39m(page�[33m,�[39m { name�[33m:�[39m profile�[33m.�[39mname�[33m,�[39m about�[33m:�[39m profile�[33m.�[39mabout })
�[90m 34 |�[39m expect(�[36mawait�[39m page�[33m.�[39mtitle())�[33m.�[39mtoBe(�[32m'Send | Profile'�[39m)
�[31m�[1m>�[22m�[39m�[90m 35 |�[39m �[36mawait�[39m expect(page�[33m.�[39mgetByText(profile�[33m.�[39mname))�[33m.�[39mtoBeVisible()
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 36 |�[39m �[36mawait�[39m expect(profilePage�[33m.�[39msendButton)�[33m.�[39mtoBeVisible()
�[90m 37 |�[39m })
�[90m 38 |�[39m�[0m

at /home/runner/_work/sendapp/sendapp/packages/playwright/tests/profile.logged-in.spec.ts:35:46

profile.onboarded.spec.ts

can visit other user profile and send by tag

chromium: ✅
firefox: ✅

can visit my own profile

chromium: ✅
firefox: ✅

can visit private profile

chromium: ✅
firefox: ✅

can view activities between another profile

chromium: ✅
firefox: ✅

send-token-upgrade.onboarded.spec.ts

can upgrade their Send Token V0 to Send Token V1

chromium: ✅
firefox: ✅

send.onboarded.spec.ts

can send USDC starting from profile page

chromium: ✅
firefox: 🚨

can send USDC using tag starting from home page

chromium: ✅
firefox: ✅

can send USDC using sendid starting from home page

chromium: ✅
firefox: ✅

can send USDC using address starting from home page

chromium: ✅
firefox: ✅

can send ETH starting from profile page

chromium: ✅
firefox: ✅

can send ETH using tag starting from home page

chromium: 🚨
firefox: ✅

can send ETH using sendid starting from home page

chromium: ✅
firefox: 🚨

can send ETH using address starting from home page

chromium: ✅
firefox: ✅

can send SEND starting from profile page

chromium: ✅
firefox: ✅

can send SEND using tag starting from home page

chromium: ✅
firefox: ✅

can send SEND using sendid starting from home page

chromium: ✅
firefox: ✅

can send SEND using address starting from home page

chromium: 🚨
firefox: ✅

sign-in.anon.spec.ts

redirect on sign-in

chromium: ❌
- Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m

Locator: getByPlaceholder('Search')
Expected: visible
Received: <element(s) not found>
Call log:
�[2m- expect.toBeVisible with timeout 5000ms�[22m
�[2m - waiting for getByPlaceholder('Search')�[22m

�[0m �[90m 36 |�[39m �[36mawait�[39m signInButton�[33m.�[39mclick()
�[90m 37 |�[39m �[36mconst�[39m sendSearchInput �[33m=�[39m page�[33m.�[39mgetByPlaceholder(�[32m'Search'�[39m)
�[31m�[1m>�[22m�[39m�[90m 38 |�[39m �[36mawait�[39m expect(sendSearchInput)�[33m.�[39mtoBeVisible()
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 39 |�[39m } �[36mfinally�[39m {
�[90m 40 |�[39m �[36mawait�[39m pg�[33m.�[39mquery(�[32m'DELETE FROM auth.users WHERE phone = $1'�[39m�[33m,�[39m [phone])�[33m.�[39m�[36mcatch�[39m((e) �[33m=>�[39m {
�[90m 41 |�[39m log(�[32m'delete failed'�[39m�[33m,�[39m e)�[0m

at /home/runner/_work/sendapp/sendapp/packages/playwright/tests/sign-in.anon.spec.ts:38:35

firefox: ❌
- Error: �[31mTimed out 5000ms waiting for �[39m�[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m()�[22m

Locator: getByPlaceholder('Search')
Expected: visible
Received: <element(s) not found>
Call log:
�[2m- expect.toBeVisible with timeout 5000ms�[22m
�[2m - waiting for getByPlaceholder('Search')�[22m

�[0m �[90m 36 |�[39m �[36mawait�[39m signInButton�[33m.�[39mclick()
�[90m 37 |�[39m �[36mconst�[39m sendSearchInput �[33m=�[39m page�[33m.�[39mgetByPlaceholder(�[32m'Search'�[39m)
�[31m�[1m>�[22m�[39m�[90m 38 |�[39m �[36mawait�[39m expect(sendSearchInput)�[33m.�[39mtoBeVisible()
�[90m |�[39m �[31m�[1m^�[22m�[39m
�[90m 39 |�[39m } �[36mfinally�[39m {
�[90m 40 |�[39m �[36mawait�[39m pg�[33m.�[39mquery(�[32m'DELETE FROM auth.users WHERE phone = $1'�[39m�[33m,�[39m [phone])�[33m.�[39m�[36mcatch�[39m((e) �[33m=>�[39m {
�[90m 41 |�[39m log(�[32m'delete failed'�[39m�[33m,�[39m e)�[0m

at /home/runner/_work/sendapp/sendapp/packages/playwright/tests/sign-in.anon.spec.ts:38:35

redirect to send confirm page on sign-in

chromium: ✅
firefox: ✅

sign-up.anon.spec.ts

can sign up

chromium: ✅
firefox: ✅

country code is selected based on geoip

chromium: ✅
firefox: ✅

skip otp for existing user trying to sign up using already used phone number

chromium: ⏭
firefox: ⏭

user can sign in with passkey from backing up page

chromium: ⏭
firefox: ⏭

user can sign in as back up using otp from backing up page

chromium: ⏭
firefox: ⏭

youngkidwarrior marked this pull request as ready for review February 19, 2025 11:04

youngkidwarrior requested a review from 0xBigBoss as a code owner February 19, 2025 11:04

0xBigBoss reviewed Feb 19, 2025

View reviewed changes

0xBigBoss approved these changes Feb 19, 2025

View reviewed changes

youngkidwarrior mentioned this pull request Feb 19, 2025

QA: Raise USDC min to test send lock #1116

Closed

Disable send route when sending is locked

fce1f69

youngkidwarrior force-pushed the disable_send_route_when_sending_is_locked branch from 6b3787f to fce1f69 Compare February 19, 2025 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable send route when sending is locked #1115

Disable send route when sending is locked #1115

youngkidwarrior commented Feb 19, 2025

youngkidwarrior commented Feb 19, 2025 •

edited

Loading

0xBigBoss left a comment

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

Disable send route when sending is locked #1115

Are you sure you want to change the base?

Disable send route when sending is locked #1115

Conversation

youngkidwarrior commented Feb 19, 2025

youngkidwarrior commented Feb 19, 2025 • edited Loading

0xBigBoss left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

Playwright Report

Summary

Suites

account-rewards.onboarded.spec.ts

can visit rewards page

account-sendtag-checkout.onboarded.spec.ts

can visit checkout page

can add a pending tag

cannot add an invalid tag name

can confirm a tag

can refer a tag

can refer multiple tags in separate transactions

cannot confirm a tag without paying

cannot add more than 5 tags

account-settings-backup.onboarded.spec.ts

can backup account

can remove a signer

account.logged-in.spec.ts

can visit account page

can update profile

activity.onboarded.spec.ts

can visit activity page and see correct activity feed

can search on activity page

home.onboarded.spec.ts

can visit token detail page

leaderboard.logged-in.spec.ts

can visit leaderboard page

onboarding.logged-in.spec.ts

can visit onboarding page

profile.anon.spec.ts

anon user can visit public profile

anon user cannot visit private profile

profile.logged-in.spec.ts

logged in user needs onboarding before visiting profile

profile.onboarded.spec.ts

can visit other user profile and send by tag

can visit my own profile

can visit private profile

can view activities between another profile

send-token-upgrade.onboarded.spec.ts

can upgrade their Send Token V0 to Send Token V1

send.onboarded.spec.ts

can send USDC starting from profile page

can send USDC using tag starting from home page

can send USDC using sendid starting from home page

can send USDC using address starting from home page

can send ETH starting from profile page

can send ETH using tag starting from home page

can send ETH using sendid starting from home page

can send ETH using address starting from home page

can send SEND starting from profile page

can send SEND using tag starting from home page

can send SEND using sendid starting from home page

can send SEND using address starting from home page

sign-in.anon.spec.ts

redirect on sign-in

redirect to send confirm page on sign-in

sign-up.anon.spec.ts

can sign up

country code is selected based on geoip

skip otp for existing user trying to sign up using already used phone number

user can sign in with passkey from backing up page

user can sign in as back up using otp from backing up page

youngkidwarrior commented Feb 19, 2025 •

edited

Loading