Skip to content

Commit

Permalink
build: remove rustyline support (reubeno#216)
Browse files Browse the repository at this point in the history
  • Loading branch information
reubeno authored and 39555 committed Oct 22, 2024
1 parent 2793712 commit 068277a
Show file tree
Hide file tree
Showing 10 changed files with 3 additions and 375 deletions.
88 changes: 2 additions & 86 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ For more details, please consult the [reference documentation on integration tes

There's a long list of OSS crates whose shoulders this project rests on. Notably, the following crates are directly relied on for major portions of shell functionality:

* [`reedline`](https://github.com/nushell/reedline) and [`rustyline`](https://github.com/kkawakam/rustyline) - for readline-like input and interactive usage
* [`reedline`](https://github.com/nushell/reedline) - for readline-like input and interactive usage
* [`clap`](https://github.com/clap-rs/clap) - command-line parsing, used both by the top-level brush CLI as well as built-in commands
* [`fancy-regex`](https://github.com/fancy-regex/fancy-regex) - relied on for everything regex
* [`tokio`](https://github.com/tokio-rs/tokio) - async, well, everything
Expand Down
4 changes: 0 additions & 4 deletions brush-interactive/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ bench = false
default = ["basic"]
basic = []
reedline = ["dep:reedline", "dep:nu-ansi-term"]
rustyline = ["dep:rustyline"]

[lints]
workspace = true
Expand All @@ -30,9 +29,6 @@ brush-core = { version = "^0.2.10", path = "../brush-core" }
indexmap = "2.6.0"
nu-ansi-term = { version = "0.50.1", optional = true }
reedline = { version = "0.36.0", optional = true }
rustyline = { package = "brush-rustyline-fork", version = "14.0.1", optional = true, features = [
"derive",
] }
thiserror = "1.0.64"
tracing = "0.1.40"

Expand Down
6 changes: 0 additions & 6 deletions brush-interactive/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ mod reedline;
#[cfg(feature = "reedline")]
pub use reedline::ReedlineShell;

// Rustyline-based shell
#[cfg(feature = "rustyline")]
mod rustyline;
#[cfg(feature = "rustyline")]
pub use rustyline::RustylineShell;

// Basic shell
#[cfg(feature = "basic")]
mod basic;
Expand Down
4 changes: 0 additions & 4 deletions brush-interactive/src/rustyline/mod.rs

This file was deleted.

Loading

0 comments on commit 068277a

Please sign in to comment.