Fix issues in number_line.py that changes in decimal_number_config["font_size"] get rewritten by number_config #2310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that changes in
decimal_number_config["font_size"]
get rewritten bynumber_config
Motivation
When working with
NumberLine
in manim v1.7.2, I found that the decimal number label's size doesn't change with differentfont_size
setting.Proposed changes
Swaping the position of
self.decimal_number_config
andnumber_config
inmerge_dicts_recursively
.(Which gives
self.decimal_number_config
a higher priority, fixing the issue.)Test
Code:
Result:
Before the change:

After the change:
