Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix to NumberPlane construction #909

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

Solara570
Copy link
Contributor

Due to move_to method, NumberPlane only works fine when the numberplane is symmetric about its center, which makes it infeasible to generate asymmetric grid, for instance, the first quadrant.

The fix is simple: replacing move_to with shift. Here's an example to test if it works.

class TestNumberplaneFix(Scene):
    def construct(self):
        self.add(NumberPlane(x_min=0, y_min=0))
        self.wait()

@TonyCrane TonyCrane merged commit d63f61b into 3b1b:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants