Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

430 fixes #2

Merged
merged 3 commits into from
Nov 8, 2023
Merged

430 fixes #2

merged 3 commits into from
Nov 8, 2023

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Nov 8, 2023

Implements a few fixes to jupyterlab#430.

  • Formatted Markdown documentation
  • Only doc change: I escaped the double quotes with single quotes, and replaced the examples with a "slightly less deprecated" way of specifying model_parameters via command-line options.
  • Only code change: Added a logging statement when the server extension initializes.

@dlqqq dlqqq added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 8, 2023
@3coins 3coins merged commit 71e2f13 into add-endpoint-args Nov 8, 2023
@dlqqq dlqqq deleted the 430-fixes branch November 8, 2023 18:41
3coins added a commit that referenced this pull request Nov 8, 2023
…jupyterlab#430)

* Endpoint args for SM endpoints

* Added model and endpoints kwargs options.

* Added configurable option for model parameters.

* Updated magics, added model_parameters, removed model_kwargs and endpoint_kwargs.

* Fixes %ai error for SM endpoints.

* Fixed docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 430 fixes (#2)

* log configured model_parameters

* fix markdown formatting in docs

* fix single quotes and use preferred traitlets CLI syntax

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: david qiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants