[fix] Random errors when webpacker fails to compile assets #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicassolato
reviewed
Oct 8, 2018
| private | ||
|
|
||
| def remove_compilation_digest | ||
| compilation_digest_path.delete if compilation_digest_path.exist? |
There was a problem hiding this comment.
Did you see rails/webpacker@d22a3c9? Do we need it here as well?
There was a problem hiding this comment.
Probably you are right @guicassolato I should have taken the master branch
Good catch thanks!
Fixed in upstream rails/webpacker#1399 Please upgrade to 4.0 when it is released
hallelujah
force-pushed
the
fix/webpacker-compilation-failed
branch
from
ad22192 to
b8170cd
Compare
|
Sadly none of those worked. Jenkins is still failing on this random error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed in upstream rails/webpacker#1399
Please upgrade to 4.0 when it is released