Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2.0 regression: Switch to dequal did not propagate into build #508

Closed
BacLuc opened this issue Jun 13, 2023 · 2 comments
Closed

5.2.0 regression: Switch to dequal did not propagate into build #508

BacLuc opened this issue Jun 13, 2023 · 2 comments

Comments

@BacLuc
Copy link

BacLuc commented Jun 13, 2023

In #497 was the switch from deep-equal to dequal.
This made our build fail because the dependency was removed, but it is still used in the build.
(in the source code everything is fine)

https://unpkg.com/browse/[email protected]/lib/elementRoleMap.js
on line 7

Change which made the build fail in our repo: https://github.com/ecamp/ecamp3/pull/3514/files#r1227772593

Failed build: https://github.com/ecamp/ecamp3/actions/runs/5250853099/jobs/9485218864?pr=3514

Error message that others find this issue:

 Cannot find module 'deep-equal' from 'node_modules/aria-query/lib/elementRoleMap.js'
@calebeby
Copy link

calebeby commented Jun 13, 2023

@BacLuc Did you see this issue: #502? Can you check if v5.2.1 fixed it for you?

@BacLuc
Copy link
Author

BacLuc commented Jun 13, 2023

No i did not look into the closed Issues, i did not occur to me that you are that fast.
5.2.1 fixes the issue.
I could have just waited, and the problem would have solved itself.
Thank you very much, and sorry for your time.

@BacLuc BacLuc closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants