-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain how and why we use bitcoin core #2473
Conversation
Explain why we chose to delegate most onchain tasks to bitcoin core (including onchain wallet management), the additional requirements that it creates and also the benefits in terms of security.
b585d7a
to
aed3b63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, otherwise LGTM
Codecov Report
@@ Coverage Diff @@
## master #2473 +/- ##
==========================================
+ Coverage 84.92% 84.99% +0.06%
==========================================
Files 198 198
Lines 15783 15812 +29
Branches 637 685 +48
==========================================
+ Hits 13404 13439 +35
+ Misses 2379 2373 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It might be useful to collaborate on a best-practices document to explore the interface between Lightning and on-chain where we could get into more technical details about the trade-offs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Explain why we chose to delegate most onchain tasks to bitcoin core (including onchain wallet management), the additional requirements that it creates and also the benefits in terms of security.