Better type_eq #2946
Merged
Better type_eq #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autoformatter in IDE bungled the tomls, one sec. |
rmalmain
reviewed
Feb 7, 2025
Cargo.toml
Outdated
| @@ -120,6 +120,7 @@ strum = "0.26.3" | |||
| strum_macros = "0.26.4" | |||
| toml = "0.8.19" # For parsing the injections toml file | |||
| typed-builder = "0.20.0" # Implement the builder pattern at compiletime | |||
| typeid = "1" # Safe type_eq that doesn't rely on std specialization | |||
There was a problem hiding this comment.
can you please fully specify the version ("1.0.0")?
we moved a few months ago to this convention for other dependencies
domenukk
reviewed
Feb 9, 2025
| // will never be called, meaning that our Cell's content remains true. | ||
| let res = [W::<T, U>(&detected, PhantomData)].clone(); | ||
| res[0].0.get() | ||
| typeid::of::<T>() == typeid::of::<U>() |
There was a problem hiding this comment.
Can we use this typeid for our SerdeAnyMap well?
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Feb 12, 2025
* typeid that doesn't suck * actually, that's not const! * format, move phantomdata to alloc feature block * a --------- Co-authored-by: Dongjia "toka" Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid dependence on std specialization. Fixes #2945.