Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add note about AutoCRLF issue #268

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

maxisam
Copy link

@maxisam maxisam commented Dec 22, 2022

@alerque
Copy link
Contributor

alerque commented Dec 22, 2022

If this is a necessary configuration on Windows shouldn't git-crypt itself be adding it the attributes?

@maxisam
Copy link
Author

maxisam commented Dec 22, 2022

I think it is because autocrlf is default/recommend to auto in Windows. I believe it might work just fine with autocrlf=false.
I don't write c++ for 20 years, so I will not mess around the code. But I think this deserves a note in the Readme, since it caused me couple hours to figure this out.

@alerque
Copy link
Contributor

alerque commented Dec 22, 2022

Yes I understand how that setting would cause unexpected line endings, the surprising bit to me is that this hasn't been bumped into before by other Windows users since that's kind of the default (if not so much de facto) usage.

@maxisam
Copy link
Author

maxisam commented Dec 22, 2022

Yeah, that makes two of us. But I don't use autocrl = true until 2 years ago. And this project doesn't have windows build until 0.7.0. So I guess not so many windows users here.

@maxisam maxisam changed the title Update Readme with workaround for Windows Doc: Add note about AutoCRLF issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants