-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion error in ForwardProblem::getSimulationStateTimepoint #2491
Comments
* Update amici to [8253a97d413cbbcfec335fb50fd1355107804e9e](AMICI-dev/AMICI@8253a97) * GHA: disable ceres due to #391 * Address amici deprecations Mysterious amici errors on GHA, specifically for Weber_BMC2015, not locally reproducible, remain AMICI-dev/AMICI#2491. They already occurred (at least) with amici v0.26.1. --- git subrepo clone --branch=8253a97d413cbbcfec335fb50fd1355107804e9e --force [email protected]:dweindl/AMICI.git deps/AMICI subrepo: subdir: "deps/AMICI" merged: "8253a97d" upstream: origin: "[email protected]:dweindl/AMICI.git" branch: "8253a97d413cbbcfec335fb50fd1355107804e9e" commit: "8253a97d" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
This happens if the solver fails right at an output timepoint (here: root-after-reinitialization error). In this case, the model state from that timepoint does not get stored in Lines 169 to 196 in 91054b3
|
Fixes a bug that lead to program termination if a root-after-reinitialization error (potentially also others) occurred at an output timepoint, because an non-existing/invalid SimulationState for that timepoint was accessed. See AMICI-dev#2491 for further details. Fixes AMICI-dev#2491.
This should fix the random test failures (AMICI-dev/AMICI#2491). ``` git subrepo clone --branch=9f562667ba74d1dfdd86514f89155644daeec4ba --force [email protected]:dweindl/AMICI.git deps/AMICI subrepo: subdir: "deps/AMICI" merged: "9f562667" upstream: origin: "[email protected]:dweindl/AMICI.git" branch: "9f562667ba74d1dfdd86514f89155644daeec4ba" commit: "9f562667" git-subrepo: version: "0.4.8" origin: "https://github.com/ingydotnet/git-subrepo" commit: "3a53c20" ```
I got the following assertion error in
ForwardProblem::getSimulationStateTimepoint
when simulating Weber_BMC2015 with AMICI 0.26.1:Needs further investigation.
Seems to be non-deterministic, but happens repeatedly.
Might be some memory corruption issue, potentially caused outside amici.
The text was updated successfully, but these errors were encountered: