Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Morello] Insufficient R_MORELLO_JUMP_SLOT documentation #69 #249

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

amilendra
Copy link
Contributor

Fix the specification for R_MORELLO_JUMP_SLOT to use the same format as R_MORELLO_RELATIVE.



Fix the specification for R_MORELLO_JUMP_SLOT to use the same format
as R_MORELLO_RELATIVE.
@simonwallis2
Copy link

LGTM

@smithp35
Copy link
Contributor

If you haven't got the necessary permission, now that this has been approved, let me know if you'd like me to merge this PR?

@amilendra
Copy link
Contributor Author

Yes please merge it for me. I don't seem to have the necessary permissions.

@smithp35 smithp35 merged commit 8c5f2f1 into ARM-software:main Jan 30, 2025
1 check passed
@jrtc27
Copy link

jrtc27 commented Feb 20, 2025

Hm, while this is the right thing for the ABI to do, it's not what Morello LLVM has implemented to date. There is https://git.morello-project.org/morello/llvm-project/-/merge_requests/296 to switch to this, but that's been stalled for just under a year. If that MR is going to be revived soon then I guess things are ok, but otherwise I'm not sure about the wisdom of merging ABI documentation that differs from what Morello LLVM implements (and presumably Morello binutils too, though that's not relevant to CheriBSD)?

@smithp35
Copy link
Contributor

@amilendra what do you want to do about https://git.morello-project.org/morello/llvm-project/-/merge_requests/296 is this something that you can pursue or hand over to someone that can?

@amilendra
Copy link
Contributor Author

I put it down last year with the expectation that Linaro would take over. If there is permission from management I can restart work on it. I think @simonwallis2 will get back to me regarding that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants