Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skillLab integration #52

Merged
merged 12 commits into from
Dec 31, 2024
Merged

feat: skillLab integration #52

merged 12 commits into from
Dec 31, 2024

Conversation

tomwwinter
Copy link
Contributor

No description provided.

@tomwwinter tomwwinter force-pushed the tw/feat/skilllab-integration branch 3 times, most recently from 4624194 to 208ad38 Compare November 28, 2024 12:20
Copy link

github-actions bot commented Dec 4, 2024

Code Coverage Analyse

Overall Project 59.7% -8.08%
Files changed 57.67%

File Coverage
SecurityConfiguration.kt 100% 🍏
ReportCalculationEventListener.kt 100% 🍏
ObjectMapperConfiguration.kt 100% 🍏
SkillLabFetchUserProfileUpdatesUseCase.kt 100% 🍏
SkillLabSyncUserProfileUseCase.kt 98.64% -1.36% 🍏
SqlSearchUserProfileUseCase.kt 94.03% -5.97% 🍏
EscoSkill.kt 91.43% -8.57% 🍏
SearchUserProfileUseCase.kt 90% -10% 🍏
FetchUserProfileUpdatesUseCase.kt 88.89% -11.11% 🍏
SkillLabUserProfileEntity.kt 85.94% -11.72% 🍏
SyncUserProfileUseCase.kt 83.33% -16.67%
UserProfileUpdateEvent.kt 76% -24%
SkillConfiguration.kt 70% -30%
SkillLabUserProfileSyncEntity.kt 69.64% -25%
SkillLabClient.kt 66.47% -29.64%
SkillConfigurationSkillLab.kt 54.96% -22.14%
SkillReferenceEntity.kt 52.94% -29.41%
DefaultCouchDbClient.kt 50.59% 🍏
AamAuthenticationConverter.kt 40.68% -59.32%
UserProfile.kt 28.45% -66.38%
Application.kt 25% 🍏
AamAccessDeniedHandler.kt 6% -90%
DefaultUserProfileUpdateConsumer.kt 0% -88%
DefaultUserProfileUpdatePublisher.kt 0% -87.76%
SkillController.kt 0% -92.15%
SkillAdminController.kt 0% -91.35%
SyncSkillsJob.kt 0% -86.08%
UserProfileUpdateEventQueueConfiguration.kt 0% -66.67%

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥇

We should add a small README to the module folder and include that architecture diagram, I think. It took me a little while until I understood the purpose of the various consumers and use cases - seeing the rough overall architecture would probably help navigate this more easily.

Otherwise code looks very clean and simple to me.

@tomwwinter tomwwinter force-pushed the tw/feat/skilllab-integration branch 2 times, most recently from d9ba26e to 6173e87 Compare December 10, 2024 20:25
@tomwwinter tomwwinter force-pushed the tw/feat/skilllab-integration branch from 519a756 to 47ca051 Compare December 23, 2024 07:54
@tomwwinter tomwwinter force-pushed the main branch 4 times, most recently from df802d7 to 56e2625 Compare December 23, 2024 11:12
fix: ObjectMapperConfiguration

fix: fallback for SkillUsage Enum

fix: pr feedback

docs: draft skill.md

Update application/aam-backend-service/src/main/resources/application.yaml

Co-authored-by: Sebastian <[email protected]>

Update application/aam-backend-service/src/main/kotlin/com/aamdigital/aambackendservice/skill/controller/SkillAdminController.kt

Co-authored-by: Sebastian <[email protected]>

Update application/aam-backend-service/src/main/kotlin/com/aamdigital/aambackendservice/skill/core/SqlSearchUserProfileUseCase.kt

Co-authored-by: Sebastian <[email protected]>

fix: di relicts

fix: pr feedback and some tests

feat: pagination for search results

feat: protect endpoints and conditional configuration

feat: skillLab admin api

feat: improve user profile search

fix: default query params and escoUri

feat: at user-profile/id endpoint

feat: add skill module with skill-api

ci: dont trigger on main pushes

docs: add skill-api-v1.yaml

ci: add publish script for external-mock-service

fix: use correct dto for skillab api

feat: add external-mocks-application with skilllab mock
@tomwwinter tomwwinter force-pushed the tw/feat/skilllab-integration branch from 47ca051 to c7e67f4 Compare December 30, 2024 06:33
@tomwwinter tomwwinter merged commit f642177 into main Dec 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants