-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skillLab integration #52
Conversation
4624194
to
208ad38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🥇
We should add a small README to the module folder and include that architecture diagram, I think. It took me a little while until I understood the purpose of the various consumers and use cases - seeing the rough overall architecture would probably help navigate this more easily.
Otherwise code looks very clean and simple to me.
.../main/kotlin/com/aamdigital/aambackendservice/reporting/changes/repository/SyncRepository.kt
Outdated
Show resolved
Hide resolved
...vice/src/main/kotlin/com/aamdigital/aambackendservice/security/AamAuthenticationConverter.kt
Outdated
Show resolved
Hide resolved
...ce/src/main/kotlin/com/aamdigital/aambackendservice/skill/controller/SkillAdminController.kt
Show resolved
Hide resolved
...rc/main/kotlin/com/aamdigital/aambackendservice/skill/skilllab/SkillLabUserProfileMatcher.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/com/aamdigital/aambackendservice/skill/repository/SkillLabUserProfileSyncEntity.kt
Show resolved
Hide resolved
...in/kotlin/com/aamdigital/aambackendservice/skill/repository/SkillLabUserProfileRepository.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/com/aamdigital/aambackendservice/skill/repository/SkillLabUserProfileEntity.kt
Outdated
Show resolved
Hide resolved
...-backend-service/src/main/kotlin/com/aamdigital/aambackendservice/skill/job/SyncSkillsJob.kt
Show resolved
Hide resolved
application/aam-backend-service/src/main/resources/application.yaml
Outdated
Show resolved
Hide resolved
...e/src/main/kotlin/com/aamdigital/aambackendservice/skill/core/SqlSearchUserProfileUseCase.kt
Outdated
Show resolved
Hide resolved
...e/src/main/kotlin/com/aamdigital/aambackendservice/skill/core/SqlSearchUserProfileUseCase.kt
Show resolved
Hide resolved
...ce/src/main/kotlin/com/aamdigital/aambackendservice/skill/controller/SkillAdminController.kt
Outdated
Show resolved
Hide resolved
d9ba26e
to
6173e87
Compare
519a756
to
47ca051
Compare
df802d7
to
56e2625
Compare
fix: ObjectMapperConfiguration fix: fallback for SkillUsage Enum fix: pr feedback docs: draft skill.md Update application/aam-backend-service/src/main/resources/application.yaml Co-authored-by: Sebastian <[email protected]> Update application/aam-backend-service/src/main/kotlin/com/aamdigital/aambackendservice/skill/controller/SkillAdminController.kt Co-authored-by: Sebastian <[email protected]> Update application/aam-backend-service/src/main/kotlin/com/aamdigital/aambackendservice/skill/core/SqlSearchUserProfileUseCase.kt Co-authored-by: Sebastian <[email protected]> fix: di relicts fix: pr feedback and some tests feat: pagination for search results feat: protect endpoints and conditional configuration feat: skillLab admin api feat: improve user profile search fix: default query params and escoUri feat: at user-profile/id endpoint feat: add skill module with skill-api ci: dont trigger on main pushes docs: add skill-api-v1.yaml ci: add publish script for external-mock-service fix: use correct dto for skillab api feat: add external-mocks-application with skilllab mock
47ca051
to
c7e67f4
Compare
Co-authored-by: Sebastian <[email protected]>
…to tw/feat/skilllab-integration
No description provided.