Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed data types of task_arns_to_instance_info #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changed data types of task_arns_to_instance_info #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions migrations/00013_add_task_arn_instance_id_table.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
CREATE TABLE task_arns_to_instance_info (
task_arn TEXT NOT NULL,
instance_id TEXT NOT NULL,
public_ip TEXT NOT NULL,
private_ip TEXT NOT NULL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to do this in a new migration file called something like 00024_make_ip_columns_optional.sql:

-- +goose Up
ALTER TABLE task_arns_to_instance_info ALTER COLUMN public_ip DROP NOT NULL;
ALTER TABLE task_arns_to_instance_info ALTER COLUMN private_ip DROP NOT NULL;

-- +goose Down
ALTER TABLE task_arns_to_instance_info ALTER COLUMN public_ip SET NOT NULL;
ALTER TABLE task_arns_to_instance_info ALTER COLUMN private_ip SET NOT NULL;

public_ip TEXT,
private_ip TEXT,
PRIMARY KEY(task_arn, instance_id)
);

Expand Down