Do not rely anymore on createFragment #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…16. Maybe this should only be a peerDependency to work both with React r15 and React r16?
…ment. (Or just wait for JSX syntax for fragments)
…nt when we can do it as directly, in my understanding)
…as we are constructing an array of child elements. Better stick with returning an array of JSX keyed elements (which will work on both React r15 and r16)
|
The Node versions for running test have been updated: this was the reason of the failure (Node v4 was getting kind of old for some dependencies to be installed). I think this is ready to be merged: been using it in production from more than one month now, with no issue. It will make the module easier to run on React v16 and thus continue to make it attractive... as it rightfully does its job! |
|
Ok, thank you. |
They could be generated by the users from their own Webpack (or other) config
Use Webpack v4 and last Babel versions
…c is simple enough classnames is great, but including it for using it one time is a bit overkill Also for AdeleD#85
(This is just latest jest-cli version that cannot install on Node 5)
Merged
|
Ok, for me this is ready to merge. To recap:
This should make the project more easier to use in modern React projects. |
Following AdeleD#189 suggestions
|
Thank you very much for your work on this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package react-addons-create-fragment is deprecated and should not be used anymore.
The recommended approach is to use an array and key fragment elements (See facebook/react#9207).
Seems we can do that easily!
An alternative would be to use the maybe-coming JSX syntax for fragments.
facebook/jsx#84
Nevertheless it still imply creating an array of fragments (instead of an object as for
createFragment).PS. I was having issues with the last version of react-paginate and React r16 due to create-fragment, so I've done this PR. (I think it works on React r16 following the version of react-addons-create-fragment used. But better not use if we can do without: the installation is simpler)
PPS. I updated some bits to make it easier to test the project.