Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Export results in the Evaluation Scenarios view #1763

Merged
merged 5 commits into from
Jun 6, 2024
+122 −27
Merged

[Feature]: Export results in the Evaluation Scenarios view #1763

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c10729
feat(frontend): export csv feature in the eval results view
bekossy Jun 5, 2024
33f142a
fixed invalid values in csv export
bekossy Jun 5, 2024
662c2bf
concatenated column name and variant in csv header
bekossy Jun 6, 2024
3c51e49
modified code to use shorthand
bekossy Jun 6, 2024
9b1af61
enhancement: used util to escape new lines break in csv export
bekossy Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
concatenated column name and variant in csv header
@bekossy
bekossy committed Jun 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 662c2bf2bd8f70ca878ba636c0d6f4f7149719be
77 changes: 54 additions & 23 deletions agenta-web/src/components/pages/evaluations/evaluationCompare/EvaluationCompare.tsx
View file
Original file line number Diff line number Diff line change
@@ -28,6 +28,7 @@ import CompareOutputDiff from "@/components/CompareOutputDiff/CompareOutputDiff"
import {formatCurrency, formatLatency} from "@/lib/helpers/formatters"
import FilterColumns, {generateFilterItems} from "../FilterColumns/FilterColumns"
import _ from "lodash"
import {variantNameWithRev} from "@/lib/helpers/variantHelper"

const useStyles = createUseStyles((theme: JSSTheme) => ({
table: {
@@ -78,6 +79,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
const [evalIds, setEvalIds] = useState(evaluationIdsArray)
const [hiddenVariants, setHiddenVariants] = useState<string[]>([])
const [fetching, setFetching] = useState(false)
const [scenarios, setScenarios] = useState<_Evaluation[]>([])
const [rows, setRows] = useState<ComparisonResultRow[]>([])
const [testset, setTestset] = useState<TestSet>()
const [evaluators] = useAtom(evaluatorsAtom)
@@ -238,7 +240,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
})

Object.entries(confgisMap).forEach(([_, configs]) => {
configs.forEach(({config, variant, color}) => {
configs.forEach(({config, variant, color}, idx) => {
colDefs.push({
flex: 1,
minWidth: 200,
@@ -259,6 +261,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
)
},
headerName: config.name,
type: `evaluator_${idx}`,
field: "variants.0.evaluatorConfigs.0.result" as any,
...getFilterParams("text"),
hide: hiddenVariants.includes(config.name),
@@ -288,6 +291,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
hide: hiddenVariants.includes("Latency"),
minWidth: 120,
headerName: "Latency",
field: `latency.${vi}` as any,
flex: 1,
valueGetter: (params) => {
const latency = params.data?.variants.find(
@@ -309,6 +313,7 @@ const EvaluationCompareMode: React.FC<Props> = () => {
</Space>
</AgCustomHeader>
),
field: `cost.${vi}` as any,
headerName: "Cost",
minWidth: 120,
hide: !evalIds.includes(variant.evaluationId) || hiddenVariants.includes("Cost"),
@@ -329,7 +334,8 @@ const EvaluationCompareMode: React.FC<Props> = () => {
const fetcher = () => {
setFetching(true)
fetchAllComparisonResults(evaluationIds)
.then(({rows, testset}) => {
.then(({rows, testset, evaluations}) => {
setScenarios(evaluations)
setRows(rows)
setTestset(testset)
setTimeout(() => {
@@ -371,13 +377,41 @@ const EvaluationCompareMode: React.FC<Props> = () => {
[colDefs],
)

const onExport = () => {
if (!gridRef.current) return
const getDynamicHeaderName = (params: ColDef): string => {
const {headerName, field, type}: any = params

const getVariantNameWithRev = (index: number): string => {
const scenario = scenarios[index]
const variantName = scenario?.variants[0]?.variantName ?? ""
const revision = scenario?.revisions[0] ?? ""
return variantNameWithRev({variant_name: variantName, revision})
}

if (headerName === "Output" || headerName === "Latency" || headerName === "Cost") {
const index = Number(field.split(".")[1])
return `${headerName} ${getVariantNameWithRev(index)}`
}

if (type && type.startsWith("evaluator")) {
const index = Number(type.split("_")[1])
return `${headerName} ${getVariantNameWithRev(index)}`
}

return headerName
}

const onExport = (): void => {
const gridApi = gridRef.current?.api
if (!gridApi) return

const {currentApp} = getAppValues()
gridRef.current.api.exportDataAsCsv({
fileName: `${currentApp?.app_name}_${variants
.map(({variantName}) => variantName)
.join("_")}.csv`,
const fileName = `${currentApp?.app_name ?? "export"}_${variants.map(({variantName}) => variantName).join("_")}.csv`

gridApi.exportDataAsCsv({
fileName,
processHeaderCallback(params) {
return getDynamicHeaderName(params.column.getColDef())
},
})
}

@@ -396,45 +430,42 @@ const EvaluationCompareMode: React.FC<Props> = () => {
<Space>
<Typography.Text strong>Variants:</Typography.Text>
<div>
{variants?.map((v, vi) => (
{scenarios?.map((v, vi) => (
<Tag
key={evaluationIds[vi]}
color={colors[vi]}
className={classes.tag}
style={{
opacity: hiddenVariants.includes(v.evaluationId)
? 0.4
: 1,
opacity: hiddenVariants.includes(v.id) ? 0.4 : 1,
}}
icon={
evalIds.length < 2 &&
evalIds.includes(
v.evaluationId,
) ? null : evalIds.includes(v.evaluationId) ? (
evalIds.includes(v.id) ? null : evalIds.includes(
v.id,
) ? (
<CloseCircleOutlined
onClick={() =>
handleToggleVariantVisibility(
v.evaluationId,
)
handleToggleVariantVisibility(v.id)
}
style={{cursor: "pointer"}}
/>
) : (
<UndoOutlined
onClick={() =>
handleToggleVariantVisibility(
v.evaluationId,
)
handleToggleVariantVisibility(v.id)
}
style={{cursor: "pointer"}}
/>
)
}
>
<Link
href={`/apps/${appId}/playground/?variant=${v.variantName}`}
href={`/apps/${appId}/playground/?variant=${v.variants[0].variantName}`}
>
{v.variantName}
{variantNameWithRev({
variant_name: v.variants[0].variantName ?? "",
revision: v.revisions[0],
})}
</Link>
</Tag>
))}
15 changes: 14 additions & 1 deletion agenta-web/src/components/pages/evaluations/evaluationScenarios/EvaluationScenarios.tsx
View file
Original file line number Diff line number Diff line change
@@ -25,6 +25,7 @@ import CompareOutputDiff from "@/components/CompareOutputDiff/CompareOutputDiff"
import {formatCurrency, formatLatency} from "@/lib/helpers/formatters"
import _ from "lodash"
import FilterColumns, {generateFilterItems} from "../FilterColumns/FilterColumns"
import {variantNameWithRev} from "@/lib/helpers/variantHelper"

const useStyles = createUseStyles((theme: JSSTheme) => ({
infoRow: {
@@ -270,6 +271,15 @@ const EvaluationScenarios: React.FC<Props> = () => {
const {currentApp} = getAppValues()
gridRef.current.api.exportDataAsCsv({
fileName: `${currentApp?.app_name}_${evalaution.variants[0].variantName}.csv`,
processHeaderCallback: (params) => {
if (params.column.getColDef().headerName === "Output") {
return `Output ${variantNameWithRev({
variant_name: evalaution?.variants[0].variantName ?? "",
revision: evalaution.revisions[0],
})}`
}
return params.column.getColDef().headerName as string
},
})
}

@@ -303,7 +313,10 @@ const EvaluationScenarios: React.FC<Props> = () => {
<Typography.Link
href={`/apps/${appId}/playground/?variant=${evalaution?.variants[0].variantName}`}
>
{evalaution?.variants[0].variantName || ""}
{variantNameWithRev({
variant_name: evalaution?.variants[0].variantName ?? "",
revision: evalaution?.revisions[0],
})}
</Typography.Link>
</Space>
</Space>
Loading