Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: error when pulling environment configuration #1797

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Fix: error when pulling environment configuration #1797

merged 2 commits into from
Jun 18, 2024

Conversation

aakrem
Copy link
Collaborator

@aakrem aakrem commented Jun 17, 2024 •
edited by aybruhm
Loading

Publishing a variant to an environment currently fails to pull the environment's configuration due to an invalid API key, causing unexpected behaviour. This PR resolves the issue.

@vercel Vercel
Copy link

vercel bot commented Jun 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 5:25pm

@aybruhm aybruhm marked this pull request as ready for review June 17, 2024 17:16
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Backend bug Something isn't working SDK labels Jun 17, 2024
@aybruhm aybruhm changed the title fix(sdk): fix passing api key Fix: error when pulling environment configuration Jun 17, 2024
@aybruhm aybruhm requested a review from mmabrouk June 17, 2024 17:19
mmabrouk
mmabrouk approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aakrem and @aybruhm for fixing this!

I think the main issues were that the application was failing silently. Both the api_key_service and config.pull were failing with a warning instead of an exception. This behavior made the bug very hard to find.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 18, 2024
@aybruhm
Copy link
Member

aybruhm commented Jun 18, 2024

Thank you @aakrem and @aybruhm for fixing this!

I think the main issues were that the application was failing silently. Both the api_key_service and config.pull were failing with a warning instead of an exception. This behavior made the bug very hard to find.

Yes, correct.

@mmabrouk mmabrouk merged commit f13398d into main Jun 18, 2024
10 checks passed
@mmabrouk mmabrouk deleted the fix-endpoint-and-playground branch June 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybruhm aybruhm aybruhm left review comments

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
Backend bug Something isn't working lgtm This PR has been approved by a maintainer SDK size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aakrem @aybruhm @mmabrouk