Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): AGE-272 Propagate func errors up in @ag.instrument() wrappers #1846

Merged
merged 4 commits into from
Jul 5, 2024
Merged

fix(sdk): AGE-272 Propagate func errors up in @ag.instrument() wrappers #1846

merged 4 commits into from
Jul 5, 2024

Conversation

jp-agenta
Copy link
Contributor

Func errors used to be set as func result. Now they are propagated up by forwarding the exception up (raise e).

@jp-agenta
fix(sdk): AGE-272 Propagate func errors up in @ag.instrument() wrappers
0bfc70b 
Func errors used to be set as func result. Now they are propagated up by forwarding the exception up (raise e).
@jp-agenta jp-agenta requested review from mmabrouk, aakrem and aybruhm July 5, 2024 10:43
@vercel Vercel
Copy link

vercel bot commented Jul 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 3:53pm

mmabrouk
mmabrouk reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jp-agenta lgtm!

@jp-agenta jp-agenta marked this pull request as ready for review July 5, 2024 12:55
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working CLI SDK labels Jul 5, 2024
@mmabrouk mmabrouk merged commit 3818fbf into main Jul 5, 2024
7 checks passed
@mmabrouk mmabrouk deleted the fix/llm-app-error-as-output-message branch July 5, 2024 16:39
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybruhm aybruhm aybruhm left review comments

@mmabrouk mmabrouk mmabrouk approved these changes

@aakrem aakrem Awaiting requested review from aakrem

Assignees
No one assigned
Labels
bug Something isn't working CLI lgtm This PR has been approved by a maintainer SDK size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jp-agenta @mmabrouk @aybruhm