refactor(backend): remove code for deleting db and tables

[aakrem]

The code was used when working on migration with main goal is to have a fresh state of tables when we adjust the migration script.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
agenta	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 10, 2024 7:29am

[aakrem]

@aybruhm Does it make sense to have a db engine only for tests. or extend it in tests to have the delete db?
I d like to be super safe and remove the delete db from the actual db engine running the app

[aybruhm]

@aybruhm Does it make sense to have a db engine only for tests. or extend it in tests to have the delete db? I d like to be super safe and remove the delete db from the actual db engine running the app

Why are we removing the codes for deleting the db and tables?

[aybruhm]

See comment.

[aakrem]

@aybruhm

1. If a user migrate agenta to a same db he's using and has a table called users_db apps_db.. (pretty standard names) it will drop them. (edge case but possible)
2. Again the drop tables are used only for dev purposes so need to have them anymore.
3. The drop db is used only in tests so why having a method in actual db engine running the app used only for tests.
4. Why keeping them ?

[aybruhm]

Keep this function.

[aybruhm]

@aybruhm

1. If a user migrate agenta to a same db he's using and has a table called users_db apps_db.. (pretty standard names) it will drop them. (edge case but possible)

2. Again the drop tables are used only for dev purposes so need to have them anymore.

3. The drop db is used only in tests so why having a method in actual db engine running the app used only for tests.

4. Why keeping them ?

Got it! Let's not remove the remove_db function yet. I'll take this over to see how it can be done with alembic and update the alembic PR.

[aybruhm]

Thank you for PR, @aakrem.