Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No hash as pyproject.toml option #1

Open
wants to merge 935 commits into
base: add-no-hash
Choose a base branch
from
Open

No hash as pyproject.toml option #1

wants to merge 935 commits into from

Conversation

Mogost
Copy link

@Mogost Mogost commented Aug 11, 2022 •
edited
Loading

Hi @donbowman. I was inspired by your solution and I have small suggestions. What do you think about such a variant of python-poetry#2654
Your implementation is way behind the master and has conflicts. I first wanted to make a rebase and apply your changes, but then I changed my mind.
Also in your implementation when using the add/remove/etc. command, a hash will appear in the file.

I just reverted you commit ff3f2af, merged current upstream, and made the change in eae0f99

I've done a couple of checks and this approach seems to work. It does not require the end user to specify options in cli.

abn and others added 30 commits May 13, 2022 17:37
@abn
ci: trigger docs on pr sync
7fcb643
@abn
install: add --no-binary option
feb11b1
@abn @neersighted
config: introduce installer.no-binary
ed26721 
This change replaces the `--no-binary` option introduced in python-poetry#5600 as
the original implementation could cause inconsistent results when the
add, update or lock commands were used.

This implementation makes use of a new configuration
`installer.no-binary` to allow for user specification of sdist
preference for select packages.
@branchvincent @neersighted
chore(repositories): remove type errors
f33c9db
@dimbleby @abn
handle importlib typing at python 3.7
f0f5ae2
@estyxx
Add --dry-run option to version command
c4e1b21 
Resolves: python-poetry#5074
@abn @neersighted
repos: ensure wheel python constraints are merged
d872f2b 
This change ensures that when http repositories inspect package
metadata from py2 and py3 wheels, python version requirements are
merged. Without this change, in cases where these wheels have different
python constraints, attempting to lock these packages will lead to
solver errors.
@johnthagen @abn
Update Windows install instructions to target the py launcher
5a563ff
@ttamg @neersighted
Documentation improvement for Zsh which needs ""
f76a33b
@ttamg @neersighted
Update docs/cli.md
6fd7fda 
Co-authored-by: Bjorn Neergaard <[email protected]>
@ttamg @neersighted
Added quotes to line 339
02dbe01
@radoering @neersighted
perf(solver): reduce the number of overrides by avoiding adding dummy…
ea335b5 
… dependencies if the project's python constraint does not allow any version compatible with the marker of the dependency
@dimbleby
tolerate poetry init in / (python-poetry#5612)
7db3e07
@hadialqattan
Adding Pycln QA tool to the pre-commit config (python-poetry#5234)
d0aa6e8
@tal66 @abn
docs: add --local option in config
839f7c4
@branchvincent @neersighted
chore(console): remove type errors
a00eb5c
@dimbleby @neersighted
retire temporary_directory()
ac3d382
@dimbleby @neersighted
remove poetry.packages.project_package
a5ab9ce
@abn @neersighted
repository: improve repo log message (python-poetry#5504)
797eb87 
Co-authored-by: Bjorn Neergaard <[email protected]>
@branchvincent
chore(inspection): remove type errors (python-poetry#5570)
f05329a
@tgolsson @abn @neersighted
add progress to download_file if in Indicator context (python-poetr…
a614b9b 
…y#5451)

Co-authored-by: Arun Babu Neelicattu <[email protected]>
Co-authored-by: Bjorn Neergaard <[email protected]>
@neersighted
ci: update to Ubuntu 22.04 and macOS 12
5d952d3 
Testing against newer versions will help us keep abreast of any upcoming
issues. The older versions can be added as partial matrix entries if
desirable, but I do not believe this to be necessary.

Also re-order mypy in the workflow so that type errors fail fast (before
tests are run).
@branchvincent
build: update dev deps
f9936e3
@branchvincent
test: address deprecation warnings
0f74791
@branchvincent
chore: remove unused type ignores
d049d8f
@gunungpw @neersighted
Add example for each section of pyproject.toml (python-poetry#5585)
147b651 
Co-authored-by: Bjorn Neergaard <[email protected]>
@nikmolnar @neersighted
Make test_installer.py tests pass from any dir
f897294
@dimbleby @neersighted
partially restore temporary_directory()
e38c045 
Use the version from poetry.core always, one implementation is enough
@branchvincent @neersighted
chore(installation): remove type errors
2ae46fa
@eyllanesc @neersighted
Change typing.Callable to collections.abc.Callable
34c55fa
timgates42 and others added 30 commits July 17, 2022 17:48
@timgates42
docs: Fix a few typos (python-poetry#6024)
fc0597c 
There are small typos in:
- tests/installation/test_pip_installer.py
- tests/utils/test_extras.py

Fixes:
- Should read `namespace` rather than `namepspace`.
- Should read `multiple` rather than `multpile`.

Signed-off-by: Tim Gates <[email protected]>
@finswimmer @neersighted
docs(faq): show tox config for different use cases
c32395b
@dimbleby @neersighted
use packaging.utils.canonicalize_name()
ff8ae32
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (python-poetry#6032)
0686427 
updates:
- [github.com/hadialqattan/pycln: v2.0.1 → v2.0.4](hadialqattan/pycln@v2.0.1...v2.0.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@Secrus @neersighted
Remove Python 3.11 from CI
3e60aed
@theunkn0wn1
Improve upload error output (python-poetry#6043)
95915f0 
* Improve information returned from upload errors
* Fix the tests to for new behavior, add one for this specific case
@neersighted @mkniewallner
docs: incorporate 1.1.14 into changelog (python-poetry#6061)
fbc0ebc 
Co-authored-by: Mathieu Kniewallner <[email protected]>

Co-authored-by: Mathieu Kniewallner <[email protected]>
@dimbleby @neersighted
remove unnecessary double-dictionary
c5ce4d0
@dimbleby @neersighted
direct access for performance
a7fef27
@dimbleby @neersighted
remove package.package stutter
bf0dbc0
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (python-poetry#6073)
ec610a3 
updates:
- [github.com/asottile/pyupgrade: v2.37.1 → v2.37.2](asottile/pyupgrade@v2.37.1...v2.37.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@dimbleby @neersighted
more typechecking
e0bc7f3
@mkniewallner
Update flake8 additional dependencies (python-poetry#6095)
b5c46f5 
* build(deps): update pre-commit additional dependencies

* chore: comply with `flake8-type-checking` following update

* chore: comply with `flake8-bugbear` following update

* refactor(tests): import `zipp` only on < 3.8
@dimbleby @radoering
revert python-poetry#5770, provide new fix (python-poetry#6058)
fd4af82 
Co-authored-by: Randy Döring <[email protected]>
@AKuederle @mkniewallner
Documented the use of the "subdirectory" parameter (python-poetry#5949)
83e6c31 
* Documented the use of the "subdirectory" parameter

* Moved the subdir documentation up

* Update docs/dependency-specification.md

Co-authored-by: Mathieu Kniewallner <[email protected]>

* Added @mkniewallner editorial changes

Co-authored-by: Mathieu Kniewallner <[email protected]>

* Fixed final URL

Co-authored-by: Mathieu Kniewallner <[email protected]>

Co-authored-by: Mathieu Kniewallner <[email protected]>
@spoorn
Resolve symlinks in locker.lock path to real physical paths (python-p…
62701fe 
…oetry#5850)

Fixes python-poetry#5849
@efugier
feat(shell_support): add nushell (python-poetry#6063)
55024b3 
* feat(shell_support): add nushell

* feat(shell_detection): bump shellingham version + no echo for nushell

Co-authored-by: emilien fugier <[email protected]>
@adamgreg @radoering @pre-commit-ci
Resolve cwd using os.path.realpath() when generating environment names (
601dc78 
python-poetry#6110)

* Resolve cwd using os.path.realpath() when generating environment names

* Add test_generate_env_name_uses_real_path() unit test

* ensure normcase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Randy Döring <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@rnestler
Add 1.1.14 tag link to CHANGELOG (python-poetry#6142)
68f4da8
@SylteA
Update repositories.md (python-poetry#6146)
97b547f 
Switch `change` to `chance`
@ashnair1 @radoering
Add test for parsing dependency specification
49b1fb2
@ashnair1 @radoering
Add tests for git urls with subdirectory
8ef2a64
@ashnair1 @radoering
Add subdirectory reference to locker.py
ed88e34 
Co-authored-by: Randy Döring <[email protected]>
@ashnair1 @radoering
Add subdirectory refs to pip installer
4afa07d 
Co-authored-by: Randy Döring <[email protected]>
@ashnair1 @radoering
Add subdirectory refs to installed_repository
c9eadbd
@ashnair1 @radoering
Add support for subdirectories in git urls
b754f29
@pre-commit-ci @Secrus
[pre-commit.ci] pre-commit autoupdate (python-poetry#6100)
8c1d168 
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/asottile/yesqa: v1.3.0 → v1.4.0](asottile/yesqa@v1.3.0...v1.4.0)
- [github.com/asottile/pyupgrade: v2.37.2 → v2.37.3](asottile/pyupgrade@v2.37.2...v2.37.3)
- [github.com/hadialqattan/pycln: v2.0.4 → v2.1.1](hadialqattan/pycln@v2.0.4...v2.1.1)
- [github.com/pycqa/flake8: 4.0.1 → 5.0.4](PyCQA/flake8@4.0.1...5.0.4)

* Update .pre-commit-config.yaml

Update flake8 plugins versions

* Update .pre-commit-config.yaml

* Fix new issues

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Bartosz Sokorski <[email protected]>
@Mogost
Revert "feat: add --no-hash option to update, preventing metadata.con…
1d65036 
…tent-hash"

This reverts commit ff3f2af.
@Mogost
Merge remote-tracking branch 'origin/master' into add-no-hash
1fa896f
@Mogost @donbowman
feat: add no_hash option in pyproject.toml
eae0f99 
Co-authored-by: Don Bowman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.