fix: remove awaita from depositMultiple

Agoric · May 4, 2021 · a7da714 · a7da714
1 parent b16ae45
commit a7da714
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/packages/vats/src/distributeFees.js b/packages/vats/src/distributeFees.js
@@ -67,7 +67,7 @@ export function buildDistributor(treasury, bank, epochTimer, timer, params) {
     const accounts = queuedAccounts.splice(0, depositsPerUpdate);
     const payments = queuedPayments.splice(0, depositsPerUpdate);
     E(bank)
-      .depositMultiple(accounts, payments)
+      .depositMultiple(runBrand, accounts, payments)
       .then(settledResults => {
         const rejectedPayments = payments.filter(
           (_pmt, i) =>

diff --git a/packages/vats/src/types.js b/packages/vats/src/types.js
@@ -53,7 +53,7 @@
 /**
  * @typedef {Object} BankDepositFacet
  *
- * @property {(accounts: string[], payments: Payment[]) => Promise<PromiseSettledResult<Amount>[]>} depositMultiple
+ * @property {(brand: Brand, accounts: string[], payments: Payment[]) => Promise<PromiseSettledResult<Amount>[]>} depositMultiple
  * @property {() => Notifier<string[]>} getAccountsNotifier
  */
 

diff --git a/packages/vats/src/vat-bank.js b/packages/vats/src/vat-bank.js
@@ -206,7 +206,7 @@ export function buildRootObject(_vatPowers) {
             const assetRecord = brandToAssetRecord.get(brand);
             if (!bankCall) {
               // Just emulate with a real purse.
-              const purse = await E(assetRecord.issuer).makeEmptyPurse();
+              const purse = E(assetRecord.issuer).makeEmptyPurse();
               brandToVPurse.init(brand, purse);
               return purse;
             }
@@ -266,22 +266,23 @@ export function buildRootObject(_vatPowers) {
           return accountsNotifier;
         },
         /**
-         * Send many independent deposits.  If any of them fail, then you should
-         * reclaim the corresponding payments since they didn't get deposited.
+         * Send many independent deposits, all of the same brand. If any of them
+         * fail, then you should reclaim the corresponding payments since they
+         * didn't get deposited.
          *
+         * @param {Brand} brand
          * @param {Array<string>} accounts
          * @param {Array<Payment>} payments
          * @returns {Promise<PromiseSettledResult<Amount>[]>}
          */
-        depositMultiple(accounts, payments) {
+        depositMultiple(brand, accounts, payments) {
           /**
            * @param {string} account
            * @param {Payment} payment
            */
-          const doDeposit = async (account, payment) => {
+          const doDeposit = (account, payment) => {
             // We can get the alleged brand, because the purse we send it to
             // will do the proper verification as part of deposit.
-            const brand = await E(payment).getAllegedBrand();
             const bank = getBankForAddress(account);
             const purse = bank.getPurse(brand);
             return E(purse).deposit(payment);