-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet should show the invitation details for the invitation to be used in an offer, in the offer inbox #3650
Comments
Can we call it |
I think that's British/Canadian English and not so much American, but yes, that's fine with me! |
Heh, you caught me. I try to write American English when it comes to code, but this one slipped through. 😊 |
Closes #3650 Other details are still available by the </> debug click.
Closes #3650 Other details are still available by the </> debug click.
Closes #3650 Other details are still available by the </> debug click.
Closes #3650 Other details are still available by the </> debug click.
Closes #3650 Other details are still available by the </> debug click.
Closes #3650 Other details are still available by the </> debug click.
What is the Problem Being Solved?
Invitations can be very valuable assets, and so the wallet should show information about the invitation used in an offer, when the user decides to approve or disapprove the offer. (Eventually, we would like the user to be able to switch out the invitation for another one, but at the very least, disapproving the offer should be possible based on the information about the invitation.)
In the next few days, the invitation details (the amount.value for the invitation) will have a fee and an expiration as well as the usual
instance
andinstallation
. We will specifically need the fee and the expiration displayed in the offer inbox, but no particular formatting is necessary. As long as the user can read the fee as a brand petname and value and the expiration as a bigint, that is fine for this stage. Even just the invitation details as a JSON string printed might be sufficient."dehydrating" in the wallet which replaces objects with the user's petnames, might be useful here.
The text was updated successfully, but these errors were encountered: