add simpler way to create comms/vattp vats #51
Assignees
Labels
SwingSet
package: SwingSet
Comments
This was referenced Dec 1, 2019
dckc
pushed a commit
to dckc/agoric-sdk
that referenced
this issue
Dec 5, 2019
Add missing src/devices/index.js with named exports from the devices' top-halves. fixes Agoric#51
dckc
pushed a commit
to dckc/agoric-sdk
that referenced
this issue
Dec 5, 2019
|
@Chris-Hibbert I think this is done now, please close if you agree |
|
I don't think so. Leaving it open as there's work to do to make creation of these vats happen by default the way we now do with the vatAdmin vat and device. |
turadg
added a commit
that referenced
this issue
Jan 17, 2025
To override 8.x in synthetic-chain that seems to be incompatible with SES: #51 20.98 TypeError#1: Invalid property descriptor. Cannot both specify accessors and a value or writable attribute, [object Object] #51 20.98 at InertConstructor.defineProperty (<anonymous>) #51 20.98 at changeToString (file:///usr/src/proposals/n:upgrade-next/node_modules/mimic-fn/index.js:57:9) #51 20.98 at mimicFunction (file:///usr/src/proposals/n:upgrade-next/node_modules/mimic-fn/index.js:68:2) #51 20.98 at onetime (file:///usr/src/proposals/n:upgrade-next/node_modules/onetime/index.js:27:2) #51 20.98 at execa (file:///usr/src/proposals/n:upgrade-next/node_modules/@agoric/synthetic-chain/node_modules/execa/index.js:160:28)
turadg
added a commit
that referenced
this issue
Jan 17, 2025
To override 8.x in synthetic-chain that seems to be incompatible with SES: #51 20.98 TypeError#1: Invalid property descriptor. Cannot both specify accessors and a value or writable attribute, [object Object] #51 20.98 at InertConstructor.defineProperty (<anonymous>) #51 20.98 at changeToString (file:///usr/src/proposals/n:upgrade-next/node_modules/mimic-fn/index.js:57:9) #51 20.98 at mimicFunction (file:///usr/src/proposals/n:upgrade-next/node_modules/mimic-fn/index.js:68:2) #51 20.98 at onetime (file:///usr/src/proposals/n:upgrade-next/node_modules/onetime/index.js:27:2) #51 20.98 at execa (file:///usr/src/proposals/n:upgrade-next/node_modules/@agoric/synthetic-chain/node_modules/execa/index.js:160:28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We shouldn't have to put stub
vat-comms.jsorvat-vattp.jsfiles into basedirs to create the comms layer. Instead there should just be someconfigflag that says "yes I want comms" and it should make the necessary vats (using standardized names so the bootstrap code can wire them up correctly).It might be nice to wire up the comms and vattp vats automatically too. Doing that will reduce the amount of boilerplate in
bootstrap.js, leaving just the initial ingress/egress calls (which we should find a way to simplify too).The text was updated successfully, but these errors were encountered: