Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquidation never takes place following rebuild from master despite conditions conducive to it, vaults hung in liquidating state and bids never fill #7796

Closed
otoole-brendan opened this issue May 18, 2023 · 3 comments · Fixed by #7803
Closed

Liquidation never takes place following rebuild from master despite conditions conducive to it, vaults hung in liquidating state and bids never fill #7796

otoole-brendan opened this issue May 18, 2023 · 3 comments · Fixed by #7803
Assignees
@Chris-Hibbert
Labels
bug Something isn't working vaults_triage DO NOT USE
Milestone
Vaults Validation

Comments

@otoole-brendan
Copy link
Contributor

Describe the bug

After rebuilding docker from master to test @Chris-Hibbert's fix #7784 - I setup test scenario for reconstitution, pushed price to trigger liquidations but liquidation never completes (even though auction continues to run).
Vaults are hung in 'liquidating' state'.

To Reproduce

Steps to reproduce the behavior:

  1. Rebuild docker against Master
  2. Set Flow 2b liquidation scenario with price of 12.34, 3x vaults + 2 bids as per:
  3. Observe default 1hour auction schedule via 'agops inter action status', wait for 1-1.5 cycles for it to pick up testing default of 10min (600s start freq) and 5mins price lock period (300s).
  4. Observe vaults go into 'liquidating' state in Vaults UI but never complete liquidation.
  5. Observe no collateral on offer and no bids filled for outstanding debt despite bids in.
  6. Observe 'liquidating' vaults stuck in loop.
  7. Observe auctions start and complete in cycles but no collateral on offer or bids filled.

Expected behavior

Expected auction schedule to have settled, liquidation to have occurred and auction complete with bids filled and 2x vaults reconstituted

Platform Environment

  • what OS are you using? what version of Node.js?
  • is there anything special/unusual about your platform?
  • what version of the Agoric-SDK are you using? (run git describe --tags --always)

Additional context

Tried changing auction params to see if it would refresh/wake-up liquidator but didn't have an effect.

Screenshots

Pasted Graphic 6

Pasted Graphic 7 Pasted Graphic 8
@otoole-brendan otoole-brendan added the bug Something isn't working label May 18, 2023
@otoole-brendan otoole-brendan added this to the Vaults Validation milestone May 18, 2023
@otoole-brendan otoole-brendan added the vaults_triage DO NOT USE label May 18, 2023
@otoole-brendan
Copy link
Contributor Author

otoole-brendan commented May 18, 2023 •
edited
Loading

Created another vault and dropped price to 9.99 to force liquidation seemed to have unstuck it a bit. The vault was actually liquidated properly and auction ticked forward selling some collateral. Vault even received excess collateral but the other 3 vaults remain stuck in state of 'liquidating'
image
image

@otoole-brendan
Copy link
Contributor Author

Was able to reproduce on another account - the 3 vaults are hung in liquidating state, auction never starts, bids are not filled, vaults not liquidated.
image
image

@dckc
Copy link
Member

dckc commented May 18, 2023

To Reproduce

  1. Rebuild docker against Master

Master is currently feb253e ; I hope that's close enough, though I suppose I could use the time this issue was opened to be sure...

@dckc dckc mentioned this issue May 18, 2023
Closed
@rowgraus rowgraus mentioned this issue May 18, 2023
Closed
@ivanlei ivanlei mentioned this issue May 19, 2023
Merged
Chris-Hibbert added a commit that referenced this issue May 19, 2023
@Chris-Hibbert
test: add a regression test for issue #7796
21abf15 
The test fails if `auctionDriver.capturePrices()` is moved from line 253 in
https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/src/auction/scheduler.js
to line 310, which matches the code before #7803
@Chris-Hibbert Chris-Hibbert mentioned this issue May 19, 2023
Merged
Chris-Hibbert added a commit that referenced this issue May 20, 2023
@Chris-Hibbert
test: add a regression test for issue #7796
5678027 
The test fails if `auctionDriver.capturePrices()` is moved from line 253 in
https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/src/auction/scheduler.js
to line 310, which matches the code before #7803
Chris-Hibbert added a commit that referenced this issue May 23, 2023
@Chris-Hibbert
test: add a regression test for issue #7796
2cade6e 
The test fails if `auctionDriver.capturePrices()` is moved from line 253 in
https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/src/auction/scheduler.js
to line 310, which matches the code before #7803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
bug Something isn't working vaults_triage DO NOT USE
Projects
None yet
Milestone
Vaults Validation
Development

Successfully merging a pull request may close this issue.

7794 capture market price at auction start Agoric/agoric-sdk
3 participants
@dckc @Chris-Hibbert @otoole-brendan