feat(xsnap): Thread a metering API #2228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
xsnap-meter
branch
from
9d42e50 to
db67eba
Compare
|
Oops. I didn't see this before working on #2384. Maybe when you get back you'd like to clean up what I did? |
|
Closing to avoid leaving inactive PRs lying around. @kriskowal you're welcome to refer to this one in a new PR or reopen if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the wiring to meter evaluation and commands in C, JS API, and the JS REPL. The only catch so far is that it doesn’t work. Failing test case included. Can be induced in REPL.