-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require virtual object selves to be declared Far #3566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a negative test, where the new assert is violated?
BTW I think it's accurate to say "Representatives are Far" rather than trying to define a "virtual object self": We use At least, that's the terminology that I use (and that I think we need) from everywhere except the interior of the virtual object manager. I guess I'm thinking the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to @erights 's recommended negative test, please also update docs/virtual-objects.md
to include the Far
requirement.
Apart from that the code changes look great.
4a549d4
to
af59fcd
Compare
af59fcd
to
f153923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes bug #3562