-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cosmic-swingset): use compute meter to decide where blocks end #3651
Conversation
note from discussion with @warner : // TODO: vatCreated() how long does vat creation take?
// in particular, contract vats (which is probably all of them)
// aim for <= 3sec of create-vat work in a block
// e.g. 3 x 1 sec |
Let's copy that file into cosmic-swingset, I don't think I want SwingSet/ to be exporting it. |
@michaelfig @warner please take a look. What do you think? p.s. I plan to squash; the 3 separate commits are not worth keeping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo a slight refactor (which needs more than just accepting the suggestions I made).
247b0e4
to
cab4728
Compare
- fix import problem - open-code computronCounter
Co-authored-by: Michael FIG <[email protected]>
cab4728
to
39bda92
Compare
lightly tested
fixes #3582
tasks:
vatCreated()
how long does vat creation take?