Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmic-swingset): use compute meter to decide where blocks end #3651

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

dckc
Copy link
Member

@dckc dckc commented Aug 10, 2021

lightly tested

fixes #3582

tasks:

  • vatCreated() how long does vat creation take?

@dckc dckc requested review from warner and michaelfig August 10, 2021 18:59
@dckc
Copy link
Member Author

dckc commented Aug 10, 2021

note from discussion with @warner :

      // TODO: vatCreated() how long does vat creation take?
      // in particular, contract vats (which is probably all of them)
      // aim for <= 3sec of create-vat work in a block
      // e.g. 3 x 1 sec

@warner
Copy link
Member

warner commented Aug 11, 2021

SyntaxError: The requested module '@agoric/swingset-vat' does not provide an export named 'computronCounter'

Let's copy that file into cosmic-swingset, I don't think I want SwingSet/ to be exporting it.

@dckc dckc changed the title feat(cosmic-swingset): use compute meter to decide where blocks end (WIP) feat(cosmic-swingset): use compute meter to decide where blocks end Aug 11, 2021
@dckc dckc marked this pull request as ready for review August 11, 2021 19:58
@dckc
Copy link
Member Author

dckc commented Aug 11, 2021

@michaelfig @warner please take a look. What do you think?

p.s. I plan to squash; the 3 separate commits are not worth keeping.

@dckc dckc added this to the Testnet: Metering Phase milestone Aug 11, 2021
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo a slight refactor (which needs more than just accepting the suggestions I made).

@dckc dckc force-pushed the 3582-cosmic-run-policy branch from 247b0e4 to cab4728 Compare August 11, 2021 22:04
@dckc dckc force-pushed the 3582-cosmic-run-policy branch from cab4728 to 39bda92 Compare August 11, 2021 22:06
@dckc dckc enabled auto-merge (squash) August 11, 2021 22:08
@dckc dckc merged commit 5f7317c into master Aug 11, 2021
@dckc dckc deleted the 3582-cosmic-run-policy branch August 11, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add run-policy to cosmic-swingset
3 participants