Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop multipool autoswap #4107

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Drop multipool autoswap #4107

merged 4 commits into from
Nov 23, 2021

Conversation

Chris-Hibbert
Copy link
Contributor

refs: #3860

Description

Remove multipoolAutoswap

Security Considerations

none

Documentation Considerations

Documentation still needs to be removed.

Testing Considerations

Tests have been removed or updated.

@Chris-Hibbert Chris-Hibbert added hygiene Tidying up around the house Small Zoe Contract Contracts within Zoe Core Economy OBSOLETE in favor of INTER-protocol labels Nov 22, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Nov 22, 2021
@Chris-Hibbert Chris-Hibbert changed the base branch from master to dropNewSwap November 22, 2021 21:05
Base automatically changed from dropNewSwap to master November 22, 2021 21:42
@Chris-Hibbert Chris-Hibbert requested a review from dckc November 22, 2021 21:57
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how the priceAuthority.js change can work without /index.js

Otherwise, yay! 6500 LOC goes bye bye!

import { makeOnewayPriceAuthorityKit } from '../../contractSupport/index.js';
import { makeOnewayPriceAuthorityKit } from '../../contractSupport';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change on purpose? I think bundleSource won't like it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not on purpose. Must have been done automatically when moving the file. I think prettier is always suggesting shortening names like this, and I never manually accept, but I'll bet it can automatically fix it when I'm not looking in some cases.

@Chris-Hibbert Chris-Hibbert added the automerge:squash Automatically squash merge label Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge Core Economy OBSOLETE in favor of INTER-protocol hygiene Tidying up around the house Zoe Contract Contracts within Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants