-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop multipool autoswap #4107
Drop multipool autoswap #4107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how the priceAuthority.js change can work without /index.js
Otherwise, yay! 6500 LOC goes bye bye!
import { makeOnewayPriceAuthorityKit } from '../../contractSupport/index.js'; | ||
import { makeOnewayPriceAuthorityKit } from '../../contractSupport'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change on purpose? I think bundleSource won't like it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on purpose. Must have been done automatically when moving the file. I think prettier is always suggesting shortening names like this, and I never manually accept, but I'll bet it can automatically fix it when I'm not looking in some cases.
refs: #3860
Description
Remove multipoolAutoswap
Security Considerations
none
Documentation Considerations
Documentation still needs to be removed.
Testing Considerations
Tests have been removed or updated.