refactor(vault): liquidate with offerArgs #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtribble
force-pushed
the
liquidation_prep
branch
from
c5d0dce to
de5daf4
Compare
* turn off unneeded tracing * pass `debt` to liquidation as an offerArg * add trace info in liquidation
dtribble
force-pushed
the
liquidation_prep
branch
from
de5daf4 to
a7d6f93
Compare
turadg
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #4568
Description
Improve liquidation separation by using
offerArgsto pass the target debt as an argument. Misc other related cleanups.Security Considerations
N/A
Documentation Considerations
Not publicly documented details at this point.
Testing Considerations
Refactoring. All tests work with the new API.