fix(agoric-cli): Thread rpcAddresses for Cosmos publishBundle

[kriskowal]

closes: #5601

Description

This change fixes #5601 which manifested as a failure to connect to a remote chain when publishing a bundle. This addresses the specific problem that publishBundle did not thread the rpcAddresses from the connection spec down to agd. This solution will be replaced with a system based on casting in cosmjs, with retries and feedback about installation success and failure #5460, but this addresses the problem until then.

[dckc]

@vejmelkam would you please try this out? @ktomascz? @anilhelvaci?

[dckc]

I haven't verified that it lets folks deploy to devnet, but it looks worthwhile in any case.

[dckc]

grumble... ambient authority...

[kriskowal]

Fair, and I can change this such that random is a power needed by makeBundlePublisher.

[kriskowal]

@vejmelkam would you please try this out? @ktomascz? @anilhelvaci?

Issue #5601 should already be mitigated by Agoric/dapp-fungible-faucet#48 on agoric-sdk/master. That is to say, you should not see connection errors on agoric-sdk/master even without this change, because agoric init will use dapp-fungible-faucet/main as a template, and the template does not use publishBundle at this time.

To manually validate that this PR addresses the underlying problem requires invoking agoric init --dapp-branch 5660-repro dapp-test to use a back-dated version of the template, one which still uses publishBundle. That version has remaining issues with deployment because publishBundle does not retry if it misses a link in the block chain, but at least should not fail with connection-refused.

When we’ve ironed out the remaining issues with publishBundle, we intend to revisit the dapp-template such that it uses publishBundle again. @michaelfig and I have decided to refactor the contract deploy script in terms of @agoric/deploy-script-helpers/install.js, and to integrate bundle publishing there.

[ktomascz]

@dckc @kriskowal

Hi, I have tested with the --dapp-branch 5660-repro dapp-test and it seems to be looking up the correct node but the address is assembled incorrectly:

➜  dapp-test git:(master) agoric deploy contract/deploy.js api/deploy.js
Open CapTP connection to ws://127.0.0.1:8000/private/captp...o
agoric: deploy: running /home/vscode/dapp-test/contract/deploy.js
agoric: deploy: Deploy script will run with Node.js ESM
agoric: deploy: /home/vscode/agoric-sdk/golang/cosmos/build/agd tx swingset install-bundle --gas auto --gas-adjustment 1.2 --home /home/vscode/dapp-test/_agstate/agoric-servers/testnet-8000/ag-cosmos-helper-statedir --node http://https://devnet.rpc.agoric.net:443 --keyring-backend test --from ag-solo --chain-id agoricdev-13 --yes @/tmp/agoric-cli-bundle--17567-ti44y7BVuJpX/bundle.json

Error: post failed: Post "http://https//devnet.rpc.agoric.net:443": dial tcp: lookup https: no such host
Usage:
  agd tx swingset install-bundle <JSON>/@<FILE>/- [flags]

Note the POST endpoint address: "http://https//devnet.rpc.agoric.net:443"

When I am testing this SDK branch with the default (main) dapp I am getting the same error as described in #5341
I am not sure these two issues are even related.

[kriskowal]

Hi, I have tested with the --dapp-branch 5660-repro dapp-test and it seems to be looking up the correct node but the address is assembled incorrectly:

Thank you for the reproduction. I’ll look into making the code that produces the address more sophisticated, to handle both the bare address and full URL cases.