Implement swingset-runner test to validate vat process failure behavior #5890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
added
SwingSet
warner
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Looks good. The one thing I might suggest is to add a comment with a link to your writeup (#2958 (comment)) , so future archaeologists can know what this is for and roughly how to use it.
turadg
force-pushed
the
2958-test-worker-process-crashing
branch
from
aa72c90 to
784f9d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
swingset-runnerdemo for testing vat process failure behavior. This requires manual testing since it is prohibitively difficult (or, at least, more difficult than we currently care to expend resources on) to automate.The issue to which this PR is responsive contains a detailed writeup of the use of this manual test and the conclusions drawn from it.
Closes #2958
Closes #5480