-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: rename from FarClass to ExoClass, etc #6323
Conversation
87d3cb8
to
fb3219e
Compare
f9e8c82
to
11e1aa8
Compare
11e1aa8
to
b9dbf1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mechanical to me. I’m warming to the idea that this name change is a net improvement and, stew as I have on this question for long enough, have not found a more positive improvement.
Caveat: this appears to be a breaking change and I do not know how it affects upgrade. However, the commit message should be framed like:
This will ensure that Lerna generates a changelog and the appropriate version bumps. |
b9dbf1e
to
75374ac
Compare
See previous discussion at #6118 |
75374ac
to
7f2a764
Compare
7f2a764
to
0d88a80
Compare
2d23251
to
1c121e5
Compare
1c121e5
to
a74084a
Compare
1c24718
to
68894d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Exo" is a big improvement over "Far", and even the isolated noun usage works pretty well.
a14bebf
to
1158b73
Compare
1158b73
to
f941e0b
Compare
Please look at #6818 for another candidate. I think I like that one better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This simple change looks good to me. As I wrote on #6323 (review) I ask that the naming rationale be documented within the codebase. E.g. packages/store/docs/terminology.md
.
b9ad4cb
to
906d4a7
Compare
8dd496d
to
223af54
Compare
223af54
to
49aeb37
Compare
49aeb37
to
e071e13
Compare
Fixes endojs/endo#1193 .
@dtribble and I were brainstorming name alternatives to
FarClass
(which we both hate for somewhat different reasons). There are three salient differences from normal object programming, whereFarClass
only suggests the first and third.this
binding (hence "Class")We also need to name the instance case, and
FarInstance
is way too awkward. The instance case has the first two features but not the third.New aha: "Exo" does double duty.
Also
But this last bullet (distinct from "Far") means that it isn't an answer to our first search for a term, since it doesn't cover remotable objects without a protective exoskeleton (currently, "Far objects" and "remote presences"). Oh well. I think the rename is still worth it.