Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix feeDistributor bootstrap #7450

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix feeDistributor bootstrap #7450

merged 2 commits into from
Apr 19, 2023

Conversation

dckc
Copy link
Member

@dckc dckc commented Apr 18, 2023

closes: #7046

Description

  • fix args to feeDistributor setup
  • route all rewards to the reserve

Security, Scaling Considerations

none

Documentation Considerations

@otoole-brendan I trust Inter docs cover this initial fee distribution policy.

Testing Considerations

I didn't add any tests.

@dckc dckc marked this pull request as ready for review April 18, 2023 21:49
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's correct to send everything to the reserve, this does that.

@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Apr 19, 2023
@mhofman
Copy link
Member

mhofman commented Apr 19, 2023

@mergify unqueue

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

unqueue

✅ The pull request has been removed from the queue

@mhofman
Copy link
Member

mhofman commented Apr 19, 2023

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

requeue

☑️ This pull request is already queued

@mhofman
Copy link
Member

mhofman commented Apr 19, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 470ca41 into master Apr 19, 2023
@mergify mergify bot deleted the 7046-dist-args branch April 19, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong args to makeOfferDestination in setting up reserve, fee distribution
3 participants