refactor(inter-protocol): jessie-check where easy #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
I'd rather not gate this on changes to swingset etc.
IMO the changes here are fine insofar as they pass CI. Since it can't merge without that I'll approve.
I don't know whether #7481 should get in before vaults release but these checks are (slightly) useful for inter protocol confidence.
erights
force-pushed
the
markm-more-jessie-checks
branch
from
f6273b4 to
e2f640f
Compare
|
turns out that this PR and #7481 happened to be disjoint, so proceeding on this one independently. |
Unstaged |
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds @jessie-check directives to inter-protocol src/**/*.js files when doing so has zero problems.
See
#3876
#5497
#7481
#7487