Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #[ts(as = "...")] dependency list #385

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Fix #[ts(as = "...")] dependency list #385

merged 3 commits into from
Mar 6, 2025

Conversation

gustavo-shigueo
Copy link
Collaborator

Goal

Using #[ts(as = "...")] at the top level of a struct would not correctly add the imports to the generated file
Closes #384

Changes

Add type_as to dependencies

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@gustavo-shigueo gustavo-shigueo added the bug Something isn't working label Mar 6, 2025
@gustavo-shigueo gustavo-shigueo merged commit 594fa30 into main Mar 6, 2025
20 checks passed
@gustavo-shigueo gustavo-shigueo deleted the fix_struct_level_as_import branch March 6, 2025 20:07
@gustavo-shigueo gustavo-shigueo mentioned this pull request Mar 6, 2025
Merged
@NyxCode
Copy link
Collaborator

NyxCode commented Mar 7, 2025

Great stuff, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Neither #[ts(type = "..")] nor #[ts(as = "..")] imports dependencies
2 participants
@gustavo-shigueo @NyxCode