fix(renovate): otter preset version with parameters #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 3db813e.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kpanot
reviewed
Mar 12, 2025
.../@o3r/workspace/schematics/ng-add/helpers/renovate/templates/__dot__renovaterc.json.template
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
fix/renovate-o3r-versions
branch
from
ee0ac0c to
e5eb06d
Compare
kpanot
reviewed
Mar 12, 2025
| "github>AmadeusITGroup/otter//tools/renovate/tasks/sdk-spec-regenerate(npm, <%= specPackageName %>)#v<%= sdkCoreVersion %>"<% } %><% } %> | ||
| "github>AmadeusITGroup/otter//tools/renovate/tasks/sdk-regenerate#v<%= sdkCoreVersion %>(npm)"<% if (specPackageName) { %>, | ||
| "github>AmadeusITGroup/otter//tools/renovate/group/sdk-spec#v<%= sdkCoreVersion %>(<%= specPackageName %>)", | ||
| "github>AmadeusITGroup/otter//tools/renovate/tasks/sdk-spec-regenerate#v<%= sdkCoreVersion %>(npm, <%= specPackageName %>)"<% } %><% } %> |
There was a problem hiding this comment.
you will need to update the associated UTs :S
in packages/@ama-sdk/schematics/schematics/typescript/shell/index.spec.ts
There was a problem hiding this comment.
for some reasons, the unit-tests were passing without changing anything
something must be wrong with the NX config
fpaul-1A
force-pushed
the
fix/renovate-o3r-versions
branch
from
e5eb06d to
743db21
Compare
kpanot
approved these changes
Mar 12, 2025
fpaul-1A
force-pushed
the
fix/renovate-o3r-versions
branch
from
743db21 to
3db813e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues
- No issue associated -